Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xCluster] Move ReplicationGroup related code out of CatalogManager #23187

Open
1 task done
Tracked by #19714
hari90 opened this issue Jul 11, 2024 · 0 comments
Open
1 task done
Tracked by #19714

[xCluster] Move ReplicationGroup related code out of CatalogManager #23187

hari90 opened this issue Jul 11, 2024 · 0 comments
Assignees
@hari90
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@hari90
Copy link
Contributor

hari90 commented Jul 11, 2024 •
edited by jira bot
Loading

Jira Link: DB-12128

Description

Move ReplicationGroup related code out of CatalogManager

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@hari90 hari90 added the area/docdb YugabyteDB core features label Jul 11, 2024
@hari90 hari90 self-assigned this Jul 11, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Jul 11, 2024
@hari90 hari90 mentioned this issue Jul 11, 2024
Open
13 tasks
hari90 added a commit that referenced this issue Jul 19, 2024
@hari90
[#23183] xCluster: Move Setup, Bootstrap, Alter and Delete Target Rep…
781af0d 
…lication functions out of CatalogManager

Summary:
Moving all functions related to Setup, Bootstrap, Alter and Delete Target Replication functions out of CatalogManager.
Setup functions have been moved to `SetupUniverseReplicationHelper` class of `xcluster_universe_replication_setup_helper.cc`
Bootstrap functions have been moved to  `SetupUniverseReplicationWithBootstrapHelper` class of `xcluster_bootstrap_helper.cc`
Alter functions have been moved to  `AlterUniverseReplicationHelper` class of `xcluster_universe_replication_alter_helper.cc`
Delete function has been moved to `xcluster_replication_group.cc`

`SetupUniverseReplication`, `IsSetupUniverseReplicationDone`, `SetupNamespaceReplicationWithBootstrap`, `IsSetupNamespaceReplicationWithBootstrapDone`, `AlterUniverseReplication`, `DeleteUniverseReplication` RPC functions have been moved to `XClusterManager` and `XClusterTargetManager`.

Moved `GetAutoFlagConfigVersionIfCompatible` from `xcluster_replication_group.cc` to `xcluster_universe_replication_setup_helper.cc`
Created new helpers `CatalogManager::GetTableGroupAndColocationInfo`, `CatalogManager::InsertNewUniverseReplication`, `CatalogManager::GetUniverseReplicationBootstrap`, `CatalogManager::InsertNewUniverseReplicationBootstrap`, `CatalogManager::InsertReplicationBootstrapToClear`, `CatalogManager::ReplaceUniverseReplication` and `CatalogManager::RemoveUniverseReplicationFromMap`. These will later be moved to XClusterManager as part of #23187

Removed some gFlags that are no longer used.
`ns_replication_sync_retry_secs`
`ns_replication_sync_backoff_secs`
`ns_replication_sync_error_backoff_secs`
`xcluster_fail_create_consumer_snapshot`
These are all either test flags or never used in production so they are safe to remove without deprecating them.

Fixes #23183
Jira: DB-12126

Test Plan: Jenkins

Reviewers: jhe, xCluster, slingam, mlillibridge

Reviewed By: mlillibridge

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D36361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hari90 hari90

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hari90 @yugabyte-ci