Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDCSDK] Make the flag yb_enable_cdc_consistent_snapshot_streams an auto flag #22984

Closed
yugabyte-ci opened this issue Jun 24, 2024 · 0 comments
Closed
Assignees
Labels
2.20.5_blocker 2024.1.1_blocker area/cdcsdk CDC SDK jira-originated kind/new-feature This is a request for a completely new feature priority/highest Highest priority issue

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented Jun 24, 2024

Jira Link: DB-11902

@yugabyte-ci yugabyte-ci added 2.20.5_blocker 2024.1.1_blocker area/cdcsdk CDC SDK jira-originated kind/new-feature This is a request for a completely new feature priority/highest Highest priority issue labels Jun 24, 2024
Sumukh-Phalgaonkar added a commit that referenced this issue Jun 24, 2024
… auto flag

Summary:
This diff promotes the flag `yb_enable_cdc_consistent_snapshot_streams` from a preview flag to a default true auto flag.
Jira: DB-11902

Test Plan: Jenkins: urgent

Reviewers: asrinivasan, skumar, stiwary

Reviewed By: asrinivasan

Subscribers: ybase, ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36084
Sumukh-Phalgaonkar added a commit that referenced this issue Jun 25, 2024
…shot_streams to auto flag

Summary:
Original commit: 9656a89 / D36084

This diff promotes the flag `yb_enable_cdc_consistent_snapshot_streams` from a preview flag to a default true auto flag.

######Backport Description
Merge conflicts were encountered due to the fact that the definition of `yb_enable_cdc_consistent_snapshot_streams` has been moved from src/yb/master/xrepl_catalog_manager.cc to src/yb/common/common_flags.cc in latest master.
Jira: DB-11902

Test Plan: Jenkins: rebase 2.20

Reviewers: asrinivasan, skumar, stiwary

Reviewed By: asrinivasan

Subscribers: ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36088
Sumukh-Phalgaonkar added a commit that referenced this issue Jun 25, 2024
…apshot_streams to auto flag

Summary:
Original commit: 9656a89 / D36084

This diff promotes the flag yb_enable_cdc_consistent_snapshot_streams from a preview flag to a default true auto flag.

######Backport Description
Merge conflicts were encountered due to the fact that the definition of yb_enable_cdc_consistent_snapshot_streams has been moved from src/yb/master/xrepl_catalog_manager.cc to src/yb/common/common_flags.cc in latest master.
Jira: DB-11902

Test Plan: Jenkins: rebase 2.20.5

Reviewers: asrinivasan, skumar, stiwary

Reviewed By: asrinivasan

Subscribers: ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36089
Sumukh-Phalgaonkar added a commit that referenced this issue Jun 25, 2024
…apshot_streams to auto flag Needs ReviewPublic

Summary:
Original commit: 9656a89 / D36084

This diff promotes the flag yb_enable_cdc_consistent_snapshot_streams from a preview flag to a default true auto flag.

######Backport Description
Minor merge conflicts were encountered in  java/yb-pgsql/src/test/java/org/yb/pgsql/TestPgReplicationSlot.java because of connection manager related changes not being backported.
Jira: DB-11902

Test Plan: Jenkins: rebase: 2024.1

Reviewers: asrinivasan, skumar, stiwary

Reviewed By: asrinivasan

Subscribers: ycdcxcluster, ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.20.5_blocker 2024.1.1_blocker area/cdcsdk CDC SDK jira-originated kind/new-feature This is a request for a completely new feature priority/highest Highest priority issue
Projects
None yet
Development

No branches or pull requests

2 participants