Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calls expired in sending queue are handled incorrectly #2269

Closed
spolitov opened this issue Sep 11, 2019 · 1 comment
Closed

Calls expired in sending queue are handled incorrectly #2269

spolitov opened this issue Sep 11, 2019 · 1 comment
Assignees
@spolitov
Labels
area/docdb YugabyteDB core features

Comments

@spolitov
Copy link
Contributor

No description provided.

@spolitov spolitov added the area/docdb YugabyteDB core features label Sep 11, 2019
@spolitov spolitov self-assigned this Sep 11, 2019
@kmuthukk
Copy link
Collaborator

Related to #2243 .

spolitov added a commit that referenced this issue Sep 12, 2019
@spolitov
[#2269]: Fix handling of calls expired in queue
3a9c364 
Summary:
The following issue occurs:
1) An outbound call is timed out while the connection is sending it.
2) Outbound call invokes and destroys callback. Callback destroys the response object.
3) After that response to this outbound call is received.
4) Outbound call tries to parse the response to the destroyed object.

Fixed by correct handling of (1), such call would not be notified when the response is received.

Test Plan: ybd --gtest_filter RpcStubTest.ExpireInQueue

Reviewers: mikhail, amitanand

Reviewed By: amitanand

Subscribers: kannan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7192
@spolitov spolitov mentioned this issue Sep 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
area/docdb YugabyteDB core features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spolitov @kmuthukk