-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YSQL] INSERT ... ON CONFLICT feature is not working for TEMP tables. #2061
Labels
Comments
Appears to work on master e0629f3, fastdebug, almalinux 8, gcc11 |
jasonyb
pushed a commit
that referenced
this issue
Aug 9, 2024
Summary: INSERT ON CONFLICT for temp tables is buggy, as shown by the issue #1999 example (same as arr_pk_tbl example here). The cause appears to be several uses of IsYugaByteEnabled where IsYBRelation should be used. Make those changes and find the repro is resolved. Also change one instance of IsYBBackedRelation to IsYBRelation. See related pg15 commit a87fee2. For tests, move the yb_pg_arrays test case to yb_dml_insert_conflict, and add the previously buggy test case to yb_pg_arrays. Also, though this didn't fail before, add issue #2061 test case to yb_dml_insert_conflict. Jira: DB-1858 Test Plan: On Almalinux 8: ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressDml ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressArrays Close: #1999 Reviewers: aagrawal Reviewed By: aagrawal Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D37104
jasonyb
pushed a commit
that referenced
this issue
Aug 12, 2024
…FLICT Summary: Merge: f69b08f - nodeModifyTable.c: - ExecOnConflictUpdate - goto yb_skip_transaction_control_check: false conflict between YB pg15 a87fee2 and YB master f69b08f. Keep pg15 version. - yb_skip_transaction_control_check: conflict between same commits. Keep pg15 version. - ExecQual: conflict between same commits plus upstream PG 277cb789836b5ddf81aabb80c2058268c70e2f36. Keep pg15 version. - (end of function): same. INSERT ON CONFLICT for temp tables is buggy, as shown by the issue #1999 example (same as arr_pk_tbl example here). The cause appears to be several uses of IsYugaByteEnabled where IsYBRelation should be used. Make those changes and find the repro is resolved. Also change one instance of IsYBBackedRelation to IsYBRelation. See related pg15 commit a87fee2. For tests, move the yb_pg_arrays test case to yb_dml_insert_conflict, and add the previously buggy test case to yb_pg_arrays. Also, though this didn't fail before, add issue #2061 test case to yb_dml_insert_conflict. Jira: DB-1858 Test Plan: On Almalinux 8: ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressDml ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressArrays Jenkins: rebase: pg15-cherrypicks Reviewers: aagrawal Reviewed By: aagrawal Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D37220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Jira Link: DB-1400
Test cases
Two rows instead of one was inserted in the following test.
The CORRECT behavior for TEMP table should have been the following.
The text was updated successfully, but these errors were encountered: