Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] flaky test: PgWrapperOneNodeClusterTest.TestPostgresPid #16487

Closed
1 task done
bmatican opened this issue Mar 20, 2023 · 0 comments
Closed
1 task done

[YSQL] flaky test: PgWrapperOneNodeClusterTest.TestPostgresPid #16487

bmatican opened this issue Mar 20, 2023 · 0 comments
Assignees
@timothy-e
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug kind/failing-test Tests and testing infra priority/medium Medium priority issue

Comments

@bmatican
Copy link
Contributor

bmatican commented Mar 20, 2023 •
edited by jira bot
Loading

Jira Link: DB-5890

Description

https://detective-gcp.dev.yugabyte.com/stability/test?analyze_trends=true&branch=master&build_type=all&class=PgWrapperOneNodeClusterTest&fail_tag=all&name=TestPostgresPid&platform=linux

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@bmatican bmatican added area/ysql Yugabyte SQL (YSQL) kind/failing-test Tests and testing infra status/awaiting-triage Issue awaiting triage labels Mar 20, 2023
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Mar 20, 2023
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Mar 28, 2023
timothy-e added a commit that referenced this issue Sep 23, 2024
@timothy-e
[#16487] YSQL: Fix flakey TestPostgresPid test
57576ae 
Summary:
`TestPostgresPid` was flaky, failing ocassionally on Jenkins and failing ~40% of the time on my devserver. The failures came from lines 364 and 380 - waiting for PG to shut down.

The problem is due to Postgres not fully initializing before the kill signal was sent. After restarting the tserver, waiting for Postgres to start allows the cluster to get into a good state.

This change also strengthens the test a bit - not only are the tservers up, but PG is ready to serve clients.
Jira: DB-5890

Test Plan:
Jenkins: test regex: .*TestPostgresPid.*
```
./yb_build.sh --cxx-test pg_wrapper-test --gtest_filter PgWrapperOneNodeClusterTest.TestPostgresPid -n 50
```

Reviewers: kramanathan

Reviewed By: kramanathan

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D38225
@yugabyte-ci yugabyte-ci assigned timothy-e and unassigned tverona1 Sep 23, 2024
foucher pushed a commit that referenced this issue Sep 24, 2024
@yugabyte-ci @foucher
[BACKPORT pg15-cherrypicks] all: Bulk port from master - 107
218324e 
Summary:
 5d3e83e [PLAT-15199] Change TP API URLs according to latest refactoring
 a50a730 [doc][yba] YBDB compatibility (#23984)
 0c84dbe [#24029] Update the callhome diagnostics  not to send gflags details.
 b53ed3a [PLAT-15379][Fix PLAT-12510] Option to use UTC when dealing with cron exp. in backup schedule
 f0eab8f [PLAT-15278]: Fix DB Scoped XCluster replication restart
 344bc76 Revert "[PLAT-15379][Fix PLAT-12510] Option to use UTC when dealing with cron exp. in backup schedule"
 3628ba7 [PLAT-14459] Swagger fix
 bb93ebe [#24021] YSQL: Add --TEST_check_catalog_version_overflow
 9ab7806 [#23927] docdb: Add gflag for minimum thread stack size
 Excluded: 8c8adc0 [#18822] YSQL: Gate update optimizations behind preview flag
 5e86515 [#23768] YSQL: Fix table rewrite DDL before slot creation
 123d496 [PLAT-14682] Universe task should only unlock itself and make unlock aware of the lock config
 de9d4ad [doc][yba] CIS hardened OS support (#23789)
 e131b20 [#23998] DocDB: Update usearch and other header-only third-party dependencies
 1665662 Automatic commit by thirdparty_tool: update usearch to commit 240fe9c298100f9e37a2d7377b1595be6ba1f412.
 3adbdae Automatic commit by thirdparty_tool: update fp16 to commit 98b0a46bce017382a6351a19577ec43a715b6835.
 9a819f7 Automatic commit by thirdparty_tool: update hnswlib to commit 2142dc6f4dd08e64ab727a7bbd93be7f732e80b0.
 2dc58f4 Automatic commit by thirdparty_tool: update simsimd to tag v5.1.0.
 9a03432 [doc][ybm] Azure private link host (#24086)
 039c9a2 [#17378] YSQL: Testing for histogram_bounds in pg_stats
 09f7a0f [#24085] DocDB: Refactor HNSW wrappers
 555af7d [#24000] DocDB: Shutting down shared exchange could cause TServer to hang
 5743a03 [PLAT-15317]Alert emails are not in the correct format.
 8642555 [PLAT-15379][Fix PLAT-12510] Option to use UTC when dealing with cron exp. in backup schedule
 253ab07 [PLAT-15400][PLAT-15401][PLAT-13051] - Connection pooling ui issues and other ui issues
 57576ae [#16487] YSQL: Fix flakey TestPostgresPid test
 bc8ae45 Update ports for CIS hardened (#24098)
 6fa33e6 [#18152, #18729] Docdb: Fix test TestPgIndexSelectiveUpdate
 cc6d2d1 [docs] added and updated cves (#24046)
 Excluded: ed153dc [#24055] YSQL: fix pg_hint_plan regression with executing prepared statement

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, jenkins-bot

Differential Revision: https://phorge.dev.yugabyte.com/D38322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothy-e timothy-e

Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug kind/failing-test Tests and testing infra priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bmatican @tverona1 @yugabyte-ci @timothy-e