Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flakiness in XCluster* tests #13600

Closed
yugabyte-ci opened this issue Aug 11, 2022 · 0 comments
Closed

Flakiness in XCluster* tests #13600

yugabyte-ci opened this issue Aug 11, 2022 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features jira-originated kind/bug This issue is a bug kind/failing-test Tests and testing infra priority/low Low priority

Comments

@yugabyte-ci
Copy link
Contributor

Jira Link: DB-3175

@yugabyte-ci yugabyte-ci added area/docdb YugabyteDB core features jira-originated kind/bug This issue is a bug kind/failing-test Tests and testing infra priority/low Low priority status/awaiting-triage Issue awaiting triage labels Aug 11, 2022
@yugabyte-ci yugabyte-ci changed the title Flakiness in XCluster* Flakiness in XCluster* tests Aug 11, 2022
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Aug 11, 2022
samiahmedsiddiqui pushed a commit to samiahmedsiddiqui/yugabyte-db that referenced this issue Aug 19, 2022
…ests

Summary:
The tests XClusterAlterUniverseAdminCliTest.TestAlterUniverseReplication* were failing because they were performing an AlterUniverseReplication using yb-admin which internally calls "IsSetupReplicationDone" on the XCluster universe with the .ALTER suffix. At the end of "AlterUniverseReplication", the universe with .ALTER is deleted and there is a code path which does not set the replication_error field in the PB correctly before returning. This results in the field retaining its default value and the yb-admin command failing with the following error:

Bad status: Runtime error (yb/util/subprocess.cc:615): Subprocess '/Users/sandeep/code/yugabyte-db/build/debug-clang-dynamic-arm64-ninja/tests-tools/../bin/yb-admin' terminated with non-zero exit status 256

The internal error is: Runtime error (yb/common/wire_protocol.cc:253): (999 unknown) which comes the default value of AppStatusPB error code of 999.

Fixed this by setting the replicationerror correctly

Test Plan: ybd --cxx-test yb-admin-test_ent --gtest_filter XClusterAlterUniverseAdminCliTest.TestAlterUniverseReplication -n 10

Reviewers: nicolas, rahuldesirazu, hsunder

Reviewed By: hsunder

Subscribers: ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D18999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features jira-originated kind/bug This issue is a bug kind/failing-test Tests and testing infra priority/low Low priority
Projects
None yet
Development

No branches or pull requests

2 participants