Skip to content

Commit

Permalink
[PLAT-15915][PLAT-15891] - fix : gflag and connection pool ui issue
Browse files Browse the repository at this point in the history
Summary:
[PLAT-15915] - Disable port override option in Edit Connection Pooling

[PLAT-15891] - Issue with text and input box wrapping on the gflag page

Test Plan:
Tested manually

**Screenshot**

{F306618}

Reviewers: kkannan

Reviewed By: kkannan

Subscribers: ui, yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D39688
  • Loading branch information
Lingeshwar committed Nov 4, 2024
1 parent 6e87f27 commit d74b41d
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ const AddGFlag = ({ formProps, gFlagProps, updateJWKSDialogStatus, disabledFlags
<Col md={6} className="split-container">
{renderFlagList()}
</Col>
<Col md={6} className="split-container add-border-left">
<Col md={6} className="detail-container add-border-left">
{renderFlagDetails()}
</Col>
</Row>
Expand Down
12 changes: 12 additions & 0 deletions managed/ui/src/components/universes/UniverseForm/UniverseForm.scss
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,18 @@
padding: 16px !important;
}

.detail-container {
flex: 1;
display: flex;
flex-direction: column;
padding: 16px !important;
overflow: scroll;

&.detail-container::-webkit-scrollbar {
display: none;
}
}

.add-border-left {
border-left: 1px solid colors.$YB_LIGHT_GRAY_BORDER;
background-color: colors.$YB_BG_WHITE_2;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ export const EditConnectionPoolModal: FC<ConnectionPoolProps> = ({
inputProps={{
'data-testid': 'EditConnectionPoolModal-OverridePorts'
}}
disabled={isItKubernetesUniverse}
/>
</Box>
{YSQL_PORTS_LIST.map((item) => (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ export const EditGflagsModal: FC<EditGflagsModalProps> = ({
flex={1}
height="100%"
data-testid="EditGflags-Modal"
style={{ scrollbarWidth: 'none' }}
>
{asyncClusterCopy && (
<Box className={classes.toggleContainer}>
Expand Down

0 comments on commit d74b41d

Please sign in to comment.