Skip to content

Commit

Permalink
#1837: Fixed TSAN issue in Partition Aware Policy for C++ Cassandra d…
Browse files Browse the repository at this point in the history
…river.

Summary:
The TSAN issue is fixed in the latest 2.9.0-yb-8 C++ Cassandra driver.
Fixed data race on 'session' pointer in the base policy class:
yugabyte/cassandra-cpp-driver@88a0837e43a58c7

Fixed data race in the updating Partitions list timer:
yugabyte/cassandra-cpp-driver@bccc76e

Test Plan: ybd tsan --cxx-test integration-tests_cassandra_cpp_driver-test --gtest_filter CppCassandraDriverTest.BatchWriteDuringSoftMemoryLimit

Reviewers: mikhail

Reviewed By: mikhail

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D9134
  • Loading branch information
OlegLoginov committed Aug 30, 2020
1 parent c7afa6e commit d3fb51a
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 10 deletions.
2 changes: 1 addition & 1 deletion build-support/thirdparty_url_centos.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
https://github.com/yugabyte/yugabyte-db-thirdparty/releases/download/v20200707012818-49ca690c1f/yugabyte-db-thirdparty-v20200707012818-49ca690c1f-centos.tar.gz
https://github.com/yugabyte/yugabyte-db-thirdparty/releases/download/v20200829090443-f431681041/yugabyte-db-thirdparty-v20200829090443-f431681041-centos.tar.gz
2 changes: 1 addition & 1 deletion build-support/thirdparty_url_mac.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
https://github.com/yugabyte/yugabyte-db-thirdparty/releases/download/v20200707012649-49ca690c1f/yugabyte-db-thirdparty-v20200707012649-49ca690c1f-macos.tar.gz
https://github.com/yugabyte/yugabyte-db-thirdparty/releases/download/v20200829090320-f431681041/yugabyte-db-thirdparty-v20200829090320-f431681041-macos.tar.gz
2 changes: 1 addition & 1 deletion build-support/thirdparty_url_ubuntu.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
https://github.com/yugabyte/yugabyte-db-thirdparty/releases/download/v20200709004310-33ee9c909c/yugabyte-db-thirdparty-v20200709004310-33ee9c909c-ubuntu.tar.gz
https://github.com/yugabyte/yugabyte-db-thirdparty/releases/download/v20200829090458-f431681041/yugabyte-db-thirdparty-v20200829090458-f431681041-ubuntu.tar.gz
6 changes: 0 additions & 6 deletions src/yb/integration-tests/cassandra_cpp_driver-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2063,12 +2063,6 @@ class CppCassandraDriverLowSoftLimitTest : public CppCassandraDriverTest {
return {"--memory_limit_soft_percentage=0"s,
"--throttle_cql_calls_on_soft_memory_limit=false"s};
}

bool UsePartitionAwareRouting() override {
// TODO: Disable partition aware routing in this test because of TSAN issue (#1837).
// Should be reenabled when issue is fixed.
return false;
}
};

TEST_F_EX(CppCassandraDriverTest, BatchWriteDuringSoftMemoryLimit,
Expand Down

0 comments on commit d3fb51a

Please sign in to comment.