Skip to content

Commit

Permalink
Parameter write-in-chunks is only used for format version 1
Browse files Browse the repository at this point in the history
If you set format-version to 2, parameter write-in-chunks has no effect.
Document this behavior.

Fixes #228
  • Loading branch information
eulerto committed Jan 26, 2022
1 parent 055d80b commit a623001
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ Parameters
* `include-default`: add default expression. Default is _false_.
* `include-pk`: add _primary key_ information as _pk_. Column name and data type is included. Default is _false_.
* `pretty-print`: add spaces and indentation to JSON structures. Default is _false_.
* `write-in-chunks`: write after every change instead of every changeset. Default is _false_.
* `write-in-chunks`: write after every change instead of every changeset. Only used when `format-version` is `1`. Default is _false_.
* `include-lsn`: add _nextlsn_ to each changeset. Default is _false_.
* `include-transaction`: emit records denoting the start and end of each transaction. Default is _true_.
* `include-unchanged-toast` (deprecated): Don't use it. It is deprecated.
Expand Down
2 changes: 1 addition & 1 deletion wal2json.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ typedef struct
bool include_pk; /* include primary key */

bool pretty_print; /* pretty-print JSON? */
bool write_in_chunks; /* write in chunks? */
bool write_in_chunks; /* write in chunks? (v1) */

JsonAction actions; /* output only these actions */

Expand Down

0 comments on commit a623001

Please sign in to comment.