-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BACKPORT 2.18][PLAT-14524] Up-version pekko to fix TLSActor infinite…
… loop Summary: We observe high CPU usage from YBA Java process on yba-installer portal with really high memory allocation rate. It will continue until YBA restart in case it happened. The issue is related to some edge case in Akka <-> JDK interaction in terms of TLS. Seems like related to TLS1.3 somehow as well: akka/akka#29922 They implemented the workaround to limit the infinite loop here, and it was working: akka/akka#31947 This fix was backported in Pekko: apache/pekko@9662048 But, if you look closer at case NEED_WRAP => code in both commits - Pekko code also has flushToUser() call, before this infinite loop check. And the issue here is that flushToUser will reset the counter they use for infinite loop check.. So, the fix does not work in Pekko, Luckily, later they had another commit in Pekko, which should fix the above issue: apache/pekko@1e41829 So, we basically need to up-version pekko. Original diffs: https://phorge.dev.yugabyte.com/D36239, https://phorge.dev.yugabyte.com/D37146 Test Plan: Tested manually that YBA works Reviewers: #yba-api-review!, nsingh, muthu, dshubin, sneelakantan Reviewed By: nsingh, muthu Subscribers: anijhawan, sneelakantan, yugaware Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D37194
- Loading branch information
1 parent
13c5ca5
commit 9bd1140
Showing
5 changed files
with
77 additions
and
64 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2190,6 +2190,9 @@ | |
| "$ref" : "#/definitions/ExtraDependencies", | ||
| "description" : "Extra dependencies" | ||
| }, | ||
| "fullBackup" : { | ||
| "type" : "boolean" | ||
| }, | ||
| "fullChainSizeInBytes" : { | ||
| "description" : "Incremental backups chain size", | ||
| "format" : "int64", | ||
|
|
@@ -2386,7 +2389,7 @@ | |
| "type" : "string" | ||
| } | ||
| }, | ||
| "required" : [ "creatingUser", "platformUrl", "platformVersion", "sleepAfterMasterRestartMillis", "sleepAfterTServerRestartMillis", "storageConfigUUID", "timeTakenPartial" ], | ||
| "required" : [ "creatingUser", "fullBackup", "platformUrl", "platformVersion", "sleepAfterMasterRestartMillis", "sleepAfterTServerRestartMillis", "storageConfigUUID", "timeTakenPartial" ], | ||
| "type" : "object" | ||
| }, | ||
| "Basic Auth information" : { | ||
|
|
@@ -5750,10 +5753,6 @@ | |
| "format" : "int64", | ||
| "type" : "integer" | ||
| }, | ||
| "isRecharts" : { | ||
| "description" : "Is Recharts", | ||
| "type" : "boolean" | ||
| }, | ||
| "metrics" : { | ||
| "description" : "Metrics", | ||
| "items" : { | ||
|
|
@@ -5779,6 +5778,9 @@ | |
| "description" : "Node prefix", | ||
| "type" : "string" | ||
| }, | ||
| "recharts" : { | ||
| "type" : "boolean" | ||
| }, | ||
| "regionCodes" : { | ||
| "description" : "Region code", | ||
| "items" : { | ||
|
|
@@ -5813,7 +5815,7 @@ | |
| "type" : "string" | ||
| } | ||
| }, | ||
| "required" : [ "start", "xclusterConfigUuid" ], | ||
| "required" : [ "recharts", "start", "xclusterConfigUuid" ], | ||
| "type" : "object" | ||
| }, | ||
| "MetricSettings" : { | ||
|
|
@@ -5980,6 +5982,9 @@ | |
| "$ref" : "#/definitions/ExtraDependencies", | ||
| "description" : "Extra dependencies" | ||
| }, | ||
| "fullBackup" : { | ||
| "type" : "boolean" | ||
| }, | ||
| "fullChainSizeInBytes" : { | ||
| "description" : "Incremental backups chain size", | ||
| "format" : "int64", | ||
|
|
@@ -6176,7 +6181,7 @@ | |
| "type" : "string" | ||
| } | ||
| }, | ||
| "required" : [ "creatingUser", "platformUrl", "platformVersion", "sleepAfterMasterRestartMillis", "sleepAfterTServerRestartMillis", "storageConfigUUID", "timeTakenPartial" ], | ||
| "required" : [ "creatingUser", "fullBackup", "platformUrl", "platformVersion", "sleepAfterMasterRestartMillis", "sleepAfterTServerRestartMillis", "storageConfigUUID", "timeTakenPartial" ], | ||
| "type" : "object" | ||
| }, | ||
| "NamespaceInfoResp" : { | ||
|
|
@@ -9143,12 +9148,6 @@ | |
| "description" : "Cron expression for the schedule", | ||
| "type" : "string" | ||
| }, | ||
| "customerUUID" : { | ||
| "description" : "Customer UUID", | ||
| "format" : "uuid", | ||
| "readOnly" : true, | ||
| "type" : "string" | ||
| }, | ||
| "failureCount" : { | ||
| "description" : "Number of failed backup attempts", | ||
| "format" : "int32", | ||
|
|
@@ -12185,10 +12184,6 @@ | |
| "example" : "[email protected]", | ||
| "type" : "string" | ||
| }, | ||
| "isPrimary" : { | ||
| "description" : "True if the user is the primary user", | ||
| "type" : "boolean" | ||
| }, | ||
| "ldapSpecifiedRole" : { | ||
| "description" : "LDAP Specified Role", | ||
| "type" : "boolean" | ||
|
|
@@ -12197,6 +12192,9 @@ | |
| "readOnly" : true, | ||
| "type" : "string" | ||
| }, | ||
| "primary" : { | ||
| "type" : "boolean" | ||
| }, | ||
| "role" : { | ||
| "description" : "User role", | ||
| "enum" : [ "ConnectOnly", "ReadOnly", "BackupAdmin", "Admin", "SuperAdmin" ], | ||
|
|
@@ -12218,7 +12216,7 @@ | |
| "type" : "string" | ||
| } | ||
| }, | ||
| "required" : [ "email" ], | ||
| "required" : [ "email", "primary" ], | ||
| "type" : "object" | ||
| }, | ||
| "Users" : { | ||
|
|
@@ -12249,10 +12247,6 @@ | |
| "example" : "[email protected]", | ||
| "type" : "string" | ||
| }, | ||
| "isPrimary" : { | ||
| "description" : "True if the user is the primary user", | ||
| "type" : "boolean" | ||
| }, | ||
| "ldapSpecifiedRole" : { | ||
| "description" : "LDAP Specified Role", | ||
| "type" : "boolean" | ||
|
|
@@ -12261,6 +12255,9 @@ | |
| "readOnly" : true, | ||
| "type" : "string" | ||
| }, | ||
| "primary" : { | ||
| "type" : "boolean" | ||
| }, | ||
| "role" : { | ||
| "description" : "User role", | ||
| "enum" : [ "ConnectOnly", "ReadOnly", "BackupAdmin", "Admin", "SuperAdmin" ], | ||
|
|
@@ -12282,7 +12279,7 @@ | |
| "type" : "string" | ||
| } | ||
| }, | ||
| "required" : [ "email" ], | ||
| "required" : [ "email", "primary" ], | ||
| "type" : "object" | ||
| }, | ||
| "VMImageUpgradeParams" : { | ||
|
|
@@ -12519,21 +12516,21 @@ | |
| "description" : { | ||
| "type" : "string" | ||
| }, | ||
| "isRequired" : { | ||
| "type" : "boolean" | ||
| }, | ||
| "isValid" : { | ||
| "required" : { | ||
| "type" : "boolean" | ||
| }, | ||
| "type" : { | ||
| "enum" : [ "NTP_SERVICE_STATUS", "PROMETHEUS_SPACE", "MOUNT_POINTS_WRITABLE", "USER", "USER_GROUP", "HOME_DIR_SPACE", "HOME_DIR_EXISTS", "RAM_SIZE", "INTERNET_CONNECTION", "CPU_CORES", "PROMETHEUS_NO_NODE_EXPORTER", "TMP_DIR_SPACE", "PAM_LIMITS_WRITABLE", "PYTHON_VERSION", "MOUNT_POINTS_VOLUME", "CHRONYD_RUNNING", "SSH_PORT", "SUDO_ACCESS", "OPENSSL", "POLICYCOREUTILS", "RSYNC", "XXHASH", "LIBATOMIC1", "LIBNCURSES6", "LIBATOMIC", "AZCOPY", "GSUTIL", "S3CMD", "NODE_EXPORTER_RUNNING", "NODE_EXPORTER_PORT", "SWAPPINESS", "ULIMIT_CORE", "ULIMIT_OPEN_FILES", "ULIMIT_USER_PROCESSES", "SYSTEMD_SUDOER_ENTRY", "SSH_ACCESS", "NODE_AGENT_ACCESS", "MASTER_HTTP_PORT", "MASTER_RPC_PORT", "TSERVER_HTTP_PORT", "TSERVER_RPC_PORT", "YB_CONTROLLER_HTTP_PORT", "YB_CONTROLLER_RPC_PORT", "REDIS_SERVER_HTTP_PORT", "REDIS_SERVER_RPC_PORT", "YCQL_SERVER_HTTP_PORT", "YCQL_SERVER_RPC_PORT", "YSQL_SERVER_HTTP_PORT", "YSQL_SERVER_RPC_PORT", "VM_MAX_MAP_COUNT" ], | ||
| "type" : "string" | ||
| }, | ||
| "valid" : { | ||
| "type" : "boolean" | ||
| }, | ||
| "value" : { | ||
| "type" : "string" | ||
| } | ||
| }, | ||
| "required" : [ "description", "isRequired", "isValid", "type", "value" ], | ||
| "required" : [ "description", "required", "type", "valid", "value" ], | ||
| "type" : "object" | ||
| }, | ||
| "VolumeDetails" : { | ||
|
|
||
Oops, something went wrong.