[pg15] refactor: misc code cleanup

Summary:
- bootstrap.c, pg_yb_utils.h: PG commit 09568ec3d31bbd4854b857e8d23c197ad5b25c77 renamed FirstBootstrapObjectId  to FirstGenbkiObjectId . YB's initial merge commit (55782d5) incorrectly introduced YbFirstBootstrapObjectId, instead of using FirstGenbkiObjectId. Clean up YbFirstBootstrapObjectId.
- utility.c:  address a trivial YB_TODO.
- cmdtaglist.h, execnodes.h: clean up non-actionable YB_TODOs. The code seems correct already.
- indexing.c: multi-tuple version of YBCExecuteInsertForDb() doesn't exist and is not required because YB buffers the operations in pggate already. Clean up the non-actionable YB_TODO.

Test Plan: Jenkins: rebase: pg15

Reviewers: jason, fizaa

Reviewed By: fizaa

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D36316

src/postgres/src/backend/bootstrap/bootstrap.c

@@ -378,13 +378,13 @@ BootstrapModeMain(int argc, char *argv[], bool check_only)
 	if (IsYugaByteEnabled())
 	{
 		YBCCreateDatabase(Template1DbOid,
-		                  "template1",
-		                  InvalidOid,
-		                  "template0",  
-		                  YbFirstBootstrapObjectId,
-		                  false /* colocated */,
-		                  NULL /* retry_on_oid_collision */,
-		                  0 /* clone_time */);
+						  "template1",
+						  InvalidOid,
+						  "template0",
+						  FirstGenbkiObjectId,
+						  false /* colocated */,
+						  NULL /* retry_on_oid_collision */,
+						  0 /* clone_time */);
 	}
 
 	/*

src/postgres/src/backend/catalog/indexing.c

@@ -477,10 +477,6 @@ CatalogTuplesMultiInsertWithInfo(Relation heapRel, TupleTableSlot **slot,
 
 	if (IsYugaByteEnabled())
 	{
-		/*
-		 *	YB_TODO(arpan): Is there a multi tuple equivalent of
-		 *	YBCExecuteInsertForDb?
-		 */
 		bool	  shouldFree;
 		HeapTuple tuple;
 		for (int i = 0; i < ntuples; i++)

src/postgres/src/backend/tcop/utility.c

@@ -2775,11 +2775,7 @@ CreateCommandTag(Node *parsetree)
 					tag = CMDTAG_DROP_TABLEGROUP;
 					break;
 				case OBJECT_YBPROFILE:
-					/* YB_TODO(neil) Needs to intro tag profile to the preprocessor.
-					 * tag = CMDTAG_DROP_PROFILE;
-					 */
-					elog(WARNING, "unrecognized commandType: drop ybprofile");
-					tag = CMDTAG_UNKNOWN;
+					tag = CMDTAG_DROP_PROFILE;
 					break;
 				default:
 					tag = CMDTAG_UNKNOWN;

src/postgres/src/include/nodes/execnodes.h

@@ -992,11 +992,6 @@ typedef struct SetExprState
 	 * (by InitFunctionCallInfoData) if func.fn_oid is valid.  It also saves
 	 * argument values between calls, when setArgsValid is true.
 	 */
-	/* YB_TODO(neil)
-	 * - Grep for this field and fix allocation.
-	 *     FunctionCallInfo fcinfo_data;
-	 * - Make sure tests work with new code.
-	 */
 	FunctionCallInfo fcinfo;
 } SetExprState;
 

src/postgres/src/include/pg_yb_utils.h

@@ -117,9 +117,6 @@ extern bool yb_enable_docdb_tracing;
 extern bool yb_read_from_followers;
 extern int32_t yb_follower_read_staleness_ms;
 
-/* YB_TODO: Remove this. */
-#define YbFirstBootstrapObjectId 10000
-
 /*
  * Iterate over databases and execute a given code snippet.
  * Should terminate with YB_FOR_EACH_DB_END.

src/postgres/src/include/tcop/cmdtaglist.h

@@ -23,10 +23,6 @@
  * textual name, so that we can bsearch on it; see GetCommandTagEnum().
  */
 
-/*
- * YB_TODO: Define Yugabyte statement tag here
- */
-
 /* symbol name, textual name, event_trigger_ok, table_rewrite_ok, rowcount */
 PG_CMDTAG(CMDTAG_UNKNOWN, "???", false, false, false)
 PG_CMDTAG(CMDTAG_ALTER_ACCESS_METHOD, "ALTER ACCESS METHOD", true, false, false)