-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BACKPORT 2024.1.1][#23260] CDCSDK: Propagate stream expiry & GC erro…
…r to walsender Summary: **Backport Description:** Minor conflict due to missing test **Original Description:** Original commit: 5ed864d / D36756 GetConsistentChanges RPC, at the moment, does not propagate any error to the walsender. But, with this diff, we will now propagate the following errors to the walsender as we cannot recover from these errors and the only solution is to create a new CDC stream. - Stream has expired - Intents have been GC'ed The consequence of sending these errors to walsender is it will lead to a crash in walsender, thereby, propagating the error further to the actual CDC client (eg: YugabyteDB connector). Such errors are not to be retried by CDC clients as these are non-recoverable errors as mentioned above. Jira: DB-12188 Test Plan: Jenkins: urgent, test regex: .*CDC.* ./yb_build.sh --cxx-test cdcsdk_consumption_consistent_changes-test --gtest_filter CDCSDKConsumptionConsistentChangesTest.TestIntentGC ./yb_build.sh --cxx-test cdcsdk_consumption_consistent_changes-test --gtest_filter CDCSDKConsumptionConsistentChangesTest.TestStreamExpiry Reviewers: asrinivasan, skumar, stiwary Reviewed By: asrinivasan Subscribers: ycdcxcluster Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D36758
- Loading branch information
1 parent
9c1af4b
commit 2f211c3
Showing
4 changed files
with
136 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters