Skip to content

Commit

Permalink
[PLAT-14324]: Move all node agent based flags from BETA to INTERNAL i…
Browse files Browse the repository at this point in the history
…n Provider Conf keys file

Summary:
We have a new guidance document for handling runtime config flags
We want to simply make a change where we have 2 types of flags, one which can be exposed and is PUBLIC and other which cannot be exposed as INTERNAL
Since these node agent flags will not be exposed to end user, we chose to make it INTERNAL

Test Plan: Please refer to code change

Reviewers: nsingh

Reviewed By: nsingh

Subscribers: yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D35889
  • Loading branch information
rajmaddy89 committed Jun 26, 2024
1 parent eccbc10 commit 199f679
Showing 1 changed file with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,15 @@ public class ProviderConfKeys extends RuntimeConfigKeysModule {
"Min Python Version (inclusive)",
"",
ConfDataType.StringType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<String> maxPyVer =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.max_python_version",
ScopeType.PROVIDER,
"Max Python Version (exclusive)",
"",
ConfDataType.StringType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<Integer> defaultAwsVolumeCount =
new ConfKeyInfo<>(
"yb.aws.default_volume_count",
Expand Down Expand Up @@ -208,87 +208,87 @@ public class ProviderConfKeys extends RuntimeConfigKeysModule {
"User",
"",
ConfDataType.StringType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<String> userGroup =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.user_group",
ScopeType.PROVIDER,
"User Group",
"",
ConfDataType.StringType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<Integer> minPrometheusSpaceMb =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.min_prometheus_space_mb",
ScopeType.PROVIDER,
"Min Prometheus Space MB",
"",
ConfDataType.IntegerType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<Integer> minTempDirSpaceMb =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.min_tmp_dir_space_mb",
ScopeType.PROVIDER,
"Min Temp Dir Space MB",
"",
ConfDataType.IntegerType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<Integer> minHomeDirSpaceMb =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.min_home_dir_space_mb",
ScopeType.PROVIDER,
"Min Home Space MB",
"",
ConfDataType.IntegerType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<Integer> minMountPointDirSpaceMb =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.min_mount_point_dir_space_mb",
ScopeType.PROVIDER,
"Min Mount Point Dir Space MB",
"",
ConfDataType.IntegerType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<String> ulimitCore =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.ulimit_core",
ScopeType.PROVIDER,
"ulimit core ",
"",
ConfDataType.StringType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<String> ulimitOpenFiles =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.ulimit_open_files",
ScopeType.PROVIDER,
"ulimit open files",
"",
ConfDataType.StringType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<String> ulimitUserProcesses =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.ulimit_user_processes",
ScopeType.PROVIDER,
"ulimit user processes",
"",
ConfDataType.StringType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<Integer> swappiness =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.swappiness",
ScopeType.PROVIDER,
"swappiness",
"",
ConfDataType.IntegerType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<Integer> sshTimeout =
new ConfKeyInfo<>(
"yb.node_agent.preflight_checks.ssh_timeout",
ScopeType.PROVIDER,
"SSH connection timeout",
"",
ConfDataType.IntegerType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));

public static final ConfKeyInfo<Boolean> enableNodeAgentClient =
new ConfKeyInfo<>(
Expand All @@ -306,7 +306,7 @@ public class ProviderConfKeys extends RuntimeConfigKeysModule {
"VM max map count",
"Max count of memory-mapped regions allowed in the system.",
ConfDataType.IntegerType,
ImmutableList.of(ConfKeyTags.BETA));
ImmutableList.of(ConfKeyTags.INTERNAL));
public static final ConfKeyInfo<Boolean> enableAnsibleOffloading =
new ConfKeyInfo<>(
"yb.node_agent.ansible_offloading.enabled",
Expand Down

0 comments on commit 199f679

Please sign in to comment.