Skip to content

Commit

Permalink
[#24753] DocDB: remove dead code yb/client/callbacks.h
Browse files Browse the repository at this point in the history
Summary:
as title.

This code is dead and appears to have been so since we originally
imported from kudu back in 2017.

Fixes #24753
Jira: DB-13838

Test Plan:
```
ybd --clean
```

Reviewers: achauhan, hsunder

Reviewed By: hsunder

Subscribers: yql, ybase

Differential Revision: https://phorge.dev.yugabyte.com/D39661
  • Loading branch information
mdbridge committed Nov 1, 2024
1 parent bf83414 commit 09b27a6
Show file tree
Hide file tree
Showing 12 changed files with 0 additions and 259 deletions.
211 changes: 0 additions & 211 deletions src/yb/client/callbacks.h

This file was deleted.

38 changes: 0 additions & 38 deletions src/yb/client/client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
#include "yb/cdc/cdc_types.h"

#include "yb/client/client_fwd.h"
#include "yb/client/callbacks.h"
#include "yb/client/client-internal.h"
#include "yb/client/client_builder-internal.h"
#include "yb/client/client_utils.h"
Expand Down Expand Up @@ -346,47 +345,10 @@ void FillFromRepeatedTabletLocations(
BOOST_PP_CAT(method, Async))); \
} while(0);

// Adapts between the internal LogSeverity and the client's YBLogSeverity.
static void LoggingAdapterCB(YBLoggingCallback* user_cb,
LogSeverity severity,
const char* filename,
int line_number,
const struct ::tm* time,
const char* message,
size_t message_len) {
YBLogSeverity client_severity;
switch (severity) {
case yb::SEVERITY_INFO:
client_severity = SEVERITY_INFO;
break;
case yb::SEVERITY_WARNING:
client_severity = SEVERITY_WARNING;
break;
case yb::SEVERITY_ERROR:
client_severity = SEVERITY_ERROR;
break;
case yb::SEVERITY_FATAL:
client_severity = SEVERITY_FATAL;
break;
default:
LOG(FATAL) << "Unknown YB log severity: " << severity;
}
user_cb->Run(client_severity, filename, line_number, time,
message, message_len);
}

void InitLogging() {
InitGoogleLoggingSafeBasic("yb_client");
}

void InstallLoggingCallback(YBLoggingCallback* cb) {
RegisterLoggingCallback(Bind(&LoggingAdapterCB, Unretained(cb)));
}

void UninstallLoggingCallback() {
UnregisterLoggingCallback();
}

void SetVerboseLogLevel(int level) {
FLAGS_v = level;
}
Expand Down
1 change: 0 additions & 1 deletion src/yb/client/ql-dml-test-base.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

#include <gtest/gtest.h>

#include "yb/client/callbacks.h"
#include "yb/client/table_handle.h"
#include "yb/common/ql_protocol.pb.h"
#include "yb/qlexpr/ql_rowblock.h"
Expand Down
1 change: 0 additions & 1 deletion src/yb/integration-tests/flush_under_load-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "yb/util/flags.h"
#include "yb/util/logging.h"

#include "yb/client/callbacks.h"
#include "yb/client/client.h"
#include "yb/client/table.h"

Expand Down
1 change: 0 additions & 1 deletion src/yb/integration-tests/full_stack-insert-scan-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@

#include "yb/gutil/casts.h"

#include "yb/client/callbacks.h"
#include "yb/client/client-test-util.h"
#include "yb/client/client.h"
#include "yb/client/error.h"
Expand Down
1 change: 0 additions & 1 deletion src/yb/integration-tests/kv_table-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "yb/util/flags.h"
#include "yb/util/logging.h"

#include "yb/client/callbacks.h"
#include "yb/client/client.h"
#include "yb/client/table.h"
#include "yb/client/tablet_server.h"
Expand Down
1 change: 0 additions & 1 deletion src/yb/integration-tests/restart-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
// under the License.
//

#include "yb/client/callbacks.h"
#include "yb/client/client.h"

#include "yb/consensus/log.h"
Expand Down
1 change: 0 additions & 1 deletion src/yb/integration-tests/retryable_request-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
// under the License.
//

#include "yb/client/callbacks.h"
#include "yb/client/client.h"
#include "yb/client/session.h"

Expand Down
1 change: 0 additions & 1 deletion src/yb/integration-tests/update_scan_delta_compact-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@

#include <boost/range/iterator_range.hpp>

#include "yb/client/callbacks.h"
#include "yb/client/client.h"
#include "yb/client/error.h"
#include "yb/client/schema.h"
Expand Down
1 change: 0 additions & 1 deletion src/yb/yql/cql/ql/exec/executor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

#include "yb/ash/wait_state.h"

#include "yb/client/callbacks.h"
#include "yb/client/client.h"
#include "yb/client/error.h"
#include "yb/client/rejection_score_source.h"
Expand Down
1 change: 0 additions & 1 deletion src/yb/yql/redis/redisserver/redis_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#include <string>

#include "yb/client/client_fwd.h"
#include "yb/client/callbacks.h"

#include "yb/yql/redis/redisserver/redis_fwd.h"

Expand Down
1 change: 0 additions & 1 deletion src/yb/yql/redis/redisserver/redis_parser.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#include <boost/algorithm/string.hpp>

#include "yb/client/callbacks.h"
#include "yb/client/yb_op.h"

#include "yb/common/redis_protocol.pb.h"
Expand Down

0 comments on commit 09b27a6

Please sign in to comment.