Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with Clang 13 #99

Merged
merged 15 commits into from
Feb 22, 2022
Merged

Conversation

mbautin
Copy link
Contributor

@mbautin mbautin commented Feb 13, 2022

Some changes that were necessary for Clang 13:

  • libc++ and libc++abi now need to be built together because libc++abi needs access to libc++ headers
  • For building libc++ and libc++abi under TSAN, a compiler wrapper hack turned out to be necessary to allow building shared objects that still have undefined TSAN-related symbols.

Other improvements:

  • Better display of long CMake command lines (breaking CMake arguments that are themselves compiler or argument lists into separate lines).

@mbautin mbautin requested a review from spolitov February 19, 2022 08:17
@mbautin mbautin requested a review from svarnau February 19, 2022 23:55
@@ -164,6 +173,53 @@ jobs:
--expected-major-compiler-version=12
--lto=full

# Clang/LLVM 13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all those build variants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would like to have Clang 12 and 13 available with both types of LTO, as well as without LTO, and with/without of Linuxbrew. Also I think maintaining two versions of Clang (the "production" one, which is 12 at the moment, and the next one) is useful.

Copy link
Member

@svarnau svarnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbautin mbautin merged commit 8050ff4 into yugabyte:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants