Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DB-13911][Sizing Calc] Remove ParallelJobs from sizing assessment recommendation as adaptive parallelism now takes care of it. #2017

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

shaharuk-yb
Copy link
Contributor

Changes:

  1. removed parallelJobs from the experiment data fetch query
  2. removed parallelJobs from the Intermediate and final recommendation object
  3. removed parallelJobs from the html template
  4. updated unit tests for sizing assessment
  5. updated the migtest (removed check for parallelJobs)

Respective JIRA task link: https://yugabyte.atlassian.net/browse/DB-13911

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@makalaaneesh makalaaneesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@sanyamsinghal sanyamsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge this PR post 2024.2 db release as discussed in today standup @makalaaneesh @hbhanawat

I hope @shaharuk-yb you are on the same page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants