-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#21963] YSQL: New read restart workloads. #98
Conversation
1a9136f
to
6e83165
Compare
4d25cc7
to
c50eabe
Compare
src/main/java/com/yugabyte/sample/apps/SqlConsistentHashing.java
Outdated
Show resolved
Hide resolved
src/main/java/com/yugabyte/sample/apps/SqlConsistentHashing.java
Outdated
Show resolved
Hide resolved
public long doRead() { | ||
try (Connection connection = getPostgresConnection(); | ||
Statement statement = connection.createStatement()) { | ||
statement.executeUpdate(String.format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in doRead
workload do a read and check consistency? And this logic can be moved in doWrite
method and activate on a coin flip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I check if there are any stale reads now. The name doRead is unfortunate but it is better to report latency and throughput separately for different operations. If we use a coin flip, then the throughput, latency numbers mix across different operations.
42e8e4a
to
51f23ed
Compare
5a7f4c2
to
b0c20ed
Compare
b0c20ed
to
2cf9a17
Compare
New Workloads
Benchmark: Restart Read Requests
Security
Change the prometheus URL to http since we start yugabyted without TLS by default. Security is not the primary concern of this change.
Cluster Setup
For wall clock configuration,
For clockbound clock configuration,
Run each sample app for 3 times for benchmarking and confidence in the metrics.