Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log at info level instead of throwing UnsupportedOperationException #95

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Log at info level instead of throwing UnsupportedOperationException #95

merged 1 commit into from
Jan 5, 2024

Conversation

ashetkar
Copy link
Contributor

@ashetkar ashetkar commented Jan 5, 2024

Log at info level instead of throwing UnsupportedOperationException in AppBase.
The workloads which do not override the methods verifyTotalRowsWritten and recordExistingRowCount were failing with message "Row count check is not supported for this workload".
Now AppBase simply logs it at info level.

kneeraj
kneeraj approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@kneeraj kneeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashetkar ashetkar merged commit 74138b9 into master Jan 5, 2024
1 check passed
@ashetkar ashetkar deleted the fix_row_count_check branch January 5, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneeraj kneeraj kneeraj approved these changes

@HarshDaryani896 HarshDaryani896 Awaiting requested review from HarshDaryani896

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashetkar @kneeraj