-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#316: ENG-3414: Script for running jepsen tests with different nemeses in a loop #10
Conversation
…nt nemeses in a loop
… config, so cluster can be restarted after wiping the data out.
yugabyte/run-jepsen.sh
Outdated
/usr/bin/timeout --foreground --kill-after=5 $TIMEOUT lein run test --nodes-file $NODES_FILE --test $test --nemesis $nemesis | ||
EC=$? | ||
set -e | ||
if [[ $EC -eq 124 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u add a comment for what's 124. I wasn't aware of it until I googled it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitanandaiyer , I've updated the script, so it doesn't use /usr/bin/timeout
, because it is hard to make it kill child processes correctly.
yugabyte/run-jepsen.sh
Outdated
EC=$? | ||
set -e | ||
if [[ $EC -eq 124 ]]; then | ||
pkill -9 java || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to grep for lein or, kill the specific pid that we launched ?
I'm concerned that we might be killing other processes -- CLion, Eclipse etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reworked that part to kill proper process group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ttyusupov . looks good.
do not run the index read during the test
yugabyte/yugabyte-db#316