Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#316: ENG-3414: Script for running jepsen tests with different nemeses in a loop #10

Merged
merged 11 commits into from
Aug 3, 2018

Conversation

ttyusupov
Copy link
Collaborator

/usr/bin/timeout --foreground --kill-after=5 $TIMEOUT lein run test --nodes-file $NODES_FILE --test $test --nemesis $nemesis
EC=$?
set -e
if [[ $EC -eq 124 ]]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u add a comment for what's 124. I wasn't aware of it until I googled it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitanandaiyer , I've updated the script, so it doesn't use /usr/bin/timeout, because it is hard to make it kill child processes correctly.

EC=$?
set -e
if [[ $EC -eq 124 ]]; then
pkill -9 java || true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to grep for lein or, kill the specific pid that we launched ?
I'm concerned that we might be killing other processes -- CLion, Eclipse etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reworked that part to kill proper process group.

Copy link

@amitanandaiyer amitanandaiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ttyusupov . looks good.

@ttyusupov ttyusupov merged commit c0f7728 into master Aug 3, 2018
@ttyusupov ttyusupov deleted the run-tests-script branch August 3, 2018 18:31
ttyusupov pushed a commit that referenced this pull request Apr 10, 2019
do not run the index read during the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants