Skip to content

Commit

Permalink
feat: Duplicate dashboard visualize (opensearch-project#148)
Browse files Browse the repository at this point in the history
* rename copy to duplicate

Signed-off-by: yuye-aws <[email protected]>

* duplicate in visualization

Signed-off-by: yuye-aws <[email protected]>

* duplicate in dashboard

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update test and snapshots

Signed-off-by: yuye-aws <[email protected]>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <[email protected]>

* remove clone for dashboard

Signed-off-by: yuye-aws <[email protected]>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <[email protected]>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <[email protected]>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <[email protected]>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <[email protected]>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <[email protected]>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <[email protected]>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <[email protected]>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <[email protected]>

* merge commits

Signed-off-by: yuye-aws <[email protected]>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* remote create vis reference logic

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <[email protected]>

* feat: skip permission validate when no workspaces and permissions attributes (opensearch-project#163)

* feat: skip permission validate when saved object without workspaces and permissions attributes

Signed-off-by: Lin Wang <[email protected]>

* feat: add annontation to skip permission check

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove bind and simplify validate logic

Signed-off-by: Lin Wang <[email protected]>

* feat: remove library write for object based ACL

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <[email protected]>

* change type definition logic

Signed-off-by: yuye-aws <[email protected]>

* Fix typo (opensearch-project#176)

---------

Signed-off-by: Yulong Ruan <[email protected]>

* remove exit workspace logic (opensearch-project#179)

Signed-off-by: yuye-aws <[email protected]>

* rename copy to duplicate

Signed-off-by: yuye-aws <[email protected]>

* duplicate in visualization

Signed-off-by: yuye-aws <[email protected]>

* duplicate in dashboard

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update test and snapshots

Signed-off-by: yuye-aws <[email protected]>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <[email protected]>

* remove clone for dashboard

Signed-off-by: yuye-aws <[email protected]>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <[email protected]>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <[email protected]>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <[email protected]>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <[email protected]>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <[email protected]>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <[email protected]>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <[email protected]>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <[email protected]>

* merge commits

Signed-off-by: yuye-aws <[email protected]>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* remote create vis reference logic

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <[email protected]>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <[email protected]>

* change type definition logic

Signed-off-by: yuye-aws <[email protected]>

* rename variable and function name

Signed-off-by: yuye-aws <[email protected]>

* change permission mode to get target workspaces when duplicate

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
Co-authored-by: Lin Wang <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
# Conflicts:
#	src/core/public/workspace/workspaces_service.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
  • Loading branch information
yuye-aws authored and yubonluo committed Mar 21, 2024
1 parent be72ad9 commit 251df79
Show file tree
Hide file tree
Showing 16 changed files with 304 additions and 210 deletions.
15 changes: 13 additions & 2 deletions src/plugins/saved_objects_management/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,22 @@ export {
ISavedObjectsManagementServiceRegistry,
SavedObjectsManagementServiceRegistryEntry,
} from './services';
export { ProcessedImportResponse, processImportResponse, FailedImport } from './lib';
export {
ProcessedImportResponse,
processImportResponse,
FailedImport,
duplicateSavedObjects,
getSavedObjectLabel,
} from './lib';
export { SavedObjectRelation, SavedObjectWithMetadata, SavedObjectMetadata } from './types';
export { SAVED_OBJECT_DELETE_TRIGGER, savedObjectDeleteTrigger } from './triggers';
export { SavedObjectDeleteContext } from './ui_actions_bootstrap';

export { SAVED_OBJECT_TYPE_WORKSPACE } from './constants';
export {
showDuplicateModal,
SavedObjectsDuplicateModal,
DuplicateMode,
} from './management_section';
export function plugin(initializerContext: PluginInitializerContext) {
return new SavedObjectsManagementPlugin();
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

import { HttpStart } from 'src/core/public';

export async function copySavedObjects(
export async function duplicateSavedObjects(
http: HttpStart,
objects: any[],
includeReferencesDeep: boolean = true,
Expand Down

This file was deleted.

3 changes: 1 addition & 2 deletions src/plugins/saved_objects_management/public/lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,4 @@ export { extractExportDetails, SavedObjectsExportResultDetails } from './extract
export { createFieldList } from './create_field_list';
export { getAllowedTypes } from './get_allowed_types';
export { filterQuery } from './filter_query';
export { copySavedObjects } from './copy_saved_objects';
export { getWorkspacesWithWritePermission } from './get_workspaces_with_write_permission';
export { duplicateSavedObjects } from './duplicate_saved_objects';
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@
*/

export { mountManagementSection } from './mount_section';
export { showDuplicateModal, SavedObjectsDuplicateModal, DuplicateMode } from './objects_table';

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 251df79

Please sign in to comment.