End the stream created when done #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,22 +28,42 @@ var gulpTape = function(opts) { | |||
|
|
|||
| var flush = function(cb) { | |||
| try { | |||
| tape.createStream(tapeOpts).pipe(reporter).pipe(outputStream); | |||
| var tapeOutput = tape.createStream(tapeOpts); | |||
There was a problem hiding this comment.
Prefer tapeStream rather than tapeOutput
|
@zoubin Am OK with merging this and cutting a |
|
@yuanqing OK. I'll release 0.0.7 later today. |
zoubin
added a commit
that referenced
this pull request
Dec 1, 2015
|
Done. 0.0.7 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10 and #8
The reason why the test task never ends in watch mode, is that
tape.getHarness()._tests.lengthincreases each time the test task finishes. So from the second time, it never ends.I end the tape output when tests are done, so that the reporter output will come before the gulp task messages and they won't mess.
However, the reporter will never receive messages created when
results.closecalled. So I push them manually.I'm not quite sure whether we should end the tape output and push the extra messages.
What do you say? @yuanqing