Skip to content

Commit

Permalink
Merge pull request dbt-labs#249 from fishtown-analytics/clrcrl/vish_f…
Browse files Browse the repository at this point in the history
…ix_test

Fix the `unpivot` test to correct behaviour of `remove`, Fix the data to align with it. fka dbt-labs#209
  • Loading branch information
Claire Carroll authored Jun 29, 2020
2 parents a3bb53e + ae3e099 commit 00a589a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions integration_tests/data/sql/data_unpivot_expected.csv
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
customer_id,created_at,prop,val
123,"2017-01-01","segment","tier 1"
123,"2017-01-01","status","active"
123,"2017-01-01","name","name 1"
234,"2017-02-01","segment","tier 3"
234,"2017-02-01","status","active"
234,"2017-02-01","name","name 3"
567,"2017-03-01","status","churned"
567,"2017-03-01","name","name 2"
567,"2017-03-01","segment","tier 2"
2 changes: 1 addition & 1 deletion integration_tests/models/sql/test_unpivot.sql
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ from (
relation=ref('data_unpivot'),
cast_to=dbt_utils.type_string(),
exclude=exclude,
remove='name',
remove=['name'],
field_name='prop',
value_name='val'
) }}
Expand Down

0 comments on commit 00a589a

Please sign in to comment.