-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should not fail when no version in python_cluster_paths #41
should not fail when no version in python_cluster_paths #41
Conversation
15523f8
to
963939a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you ensure that you have an appropriate Python version on the cluster and which one to use for running cluster parts of the job?
I assume that the cluster has the matching version and the UDFs will fail to start if it doesn't.
I am not sure if I understood the question, but my code uses different python executables based on the supplied version. |
I've checked it on out cluster an it seem to work, so the idea to get rid of `` sounds reasonable. But you also need to do modifications in these parts of the project: Write a compat comment for The else clause can be safely removed, but check your clusters, maybe they also using old spyt version, in this case it also should be preserved and marked with comment Remove all The tests should also be modified: And this legacy atavism should also be removed |
4b7a534
to
e4b2957
Compare
@alextokarew has imported your pull request. If you are a Yandex employee, you can view this diff. |
This PR #44 was successfully merged so we can close this one |
It is another one that should be closed. |
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
No description --- Pull Request resolved: #41 commit_hash:89146f50d1632032aea98ce23463b3babfe3df66
No description provided.