-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UpdateSelector needs to be decoupled #325
Comments
|
I guess some groups of component kinds should be supported (something like current StatelessOnly and stuff, but need think bit better about it than last time) |
As I see there are three levels:
So, we could rearrange existing enum to reflect that. |
Also we need:
From the config ux/code perspective it would be convienient to have empty value as nothing and group selector "Everything", but it will require "Everything" to be default value here on crd level (which I don't like very much, but guess it is fine). I don't know if list field can have default value though. |
Does not update and show explaining status is safe and sane default option. |
I don't know if our users are expecting that they will need to expicitly set field in their spec to be able to update cluster, but maybe it is ok. Need to discuss |
I expect that all known users are smart enough. |
I guess if we are adding new field we can switch the default to "No updates" if we introduce some kind of "UpdateBlocked" status for the resource (with event maybe) |
So to sum things up:
IsFulUpdate and updateSelector fields should be converted in relevant |
UpdateSelector has fixed amount of values now that do not cover all combinations of possible and reasonable updates.
In my case I wanted to update HttpProxy and QueryTrackers, and only UpdateSelector: StatelessOnly allows me to do it and it forces me to update execNodes and DataNodes too.
I suggest either:
QUERY_TRACKER | HTTP_PROXY
true
by default:updateQueryTracker: true; updateHttpProxy=true...
The text was updated successfully, but these errors were encountered: