[closertotruth] Add new extractor #8680
Conversation
Removed print statement from code. Replaced two regex searches with the corret ones. Removed some unnecessary semicolumns fixed title extraction refactored everything to search_regex
| #request video url at kaltura API | ||
| #from: http://knowledge.kaltura.com/faq/how-retrieve-download-or-streaming-url-using-api-calls | ||
| api_request_url = 'http://www.kaltura.com/p/'+p_id+'/sp/0/playManifest/entryId/'+entry_id+'/protocol/HTTPS/flavorParamId/0/video.mp4' | ||
| api_response = self._download_webpage(api_request_url, video_id) |
There was a problem hiding this comment.
Extraction should be delegated to kaltura extractor.
|
Check code with flake8 and fix all issues. |
|
how about this? :) |
|
|
||
|
|
||
| class CloserToTruthIE(InfoExtractor): | ||
| _VALID_URL = r'http?://(?:www\.)?closertotruth\.com/series/\S+#video-(?P<id>\w+)' |
There was a problem hiding this comment.
It should be https? not http?. Change \S+ to [^#]+.
|
I've processed your feedback, thanks! I believe everything has been fixed, except for one comment. If you have any other feedback please let us know. |
|
There are also different URL schema possible http://closertotruth.com/interviews/1725. |
|
The URL http://closertotruth.com/episodes/how-do-brains-work you propose does not contain clear links that point to video's that appear to belong to a kind of playlist that is available without paying for it. |
|
|
|
@dstftw thanks for the feedback, is there anything else I could have overseen? |
|
Since #8497 landed, please move changes in |
Solves issue #8435