Add support for cbc.ca #6342
Closed
Add support for cbc.ca #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| webpage = self._download_webpage(url, name) | ||
| title = unescapeHTML( | ||
| self._search_regex('<title>\s*(.+?)\s*</title>', webpage, 'title')) |
There was a problem hiding this comment.
Doesn't _html_search_regexwork here?
|
I'm interested in that too , and the tests seem to be working. Any chance this was a travis fluke and can be tried again? |
|
Since #8497 landed, please move changes in |
Closed
yan12125
pushed a commit
that referenced
this pull request
May 20, 2016
The URL http://www.cbc.ca/player/News/ID/2672225049/ (#6342) redirects to http://www.cbc.ca/player/play/2672224672, while youtube-dl wasn't able to handle it correctly.
|
Since @remitamine has pushed his/her own implementation in 8b85ac3, this PR is no longer necessary. |
TRox1972
referenced
this pull request
in TRox1972/youtube-dl
May 20, 2016
The URL http://www.cbc.ca/player/News/ID/2672225049/ (#6342) redirects to http://www.cbc.ca/player/play/2672224672, while youtube-dl wasn't able to handle it correctly.
TRox1972
referenced
this pull request
in TRox1972/youtube-dl
May 21, 2016
The URL http://www.cbc.ca/player/News/ID/2672225049/ (#6342) redirects to http://www.cbc.ca/player/play/2672224672, while youtube-dl wasn't able to handle it correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.