Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix audio conversion not working with newer versions of ffmpeg #623

Closed
wants to merge 1 commit into from

Conversation

nerdinand
Copy link

I tried to run the following command with the newest youtube-dl version and ffmpeg 1.1 installed and got an error:

$ youtube-dl -x -k "https://www.youtube.com/playlist?list=PLr9rc7slvdRXfdRUITmYArOtB-99mr5h5"
[youtube] PL r9rc7slvdRXfdRUITmYArOtB-99mr5h5: Downloading page #1
[youtube] PL r9rc7slvdRXfdRUITmYArOtB-99mr5h5: Found 25 videos
[youtube] Setting language
[youtube] ytKvgLuy7ng: Downloading video webpage
[youtube] ytKvgLuy7ng: Downloading video info webpage
[youtube] ytKvgLuy7ng: Extracting video information
[download] Destination: ytKvgLuy7ng.mp4
[download] 100.0% of 82.40M at 1.33M/s ETA 00:00
[ffmpeg] Destination: ytKvgLuy7ng.aac
ERROR: audio conversion failed: Error splitting the argument list: Option not found

The error occurs because in newer versions, ffmpeg doesn't accept the -- option any more:
$ ffmpeg -y -i ytKvgLuy7ng.mp4 -vn -acodec copy -f adts -- ytKvgLuy7ng.aac
Unrecognized option '-'.
Error splitting the argument list: Option not found

So I did some poking around in the code and found a solution which on my system works with at least versions 0.11.1 and 1.1 of ffmpeg.

@phihag
Copy link
Contributor

phihag commented Jan 9, 2013

How else will filenames starting with a - be distinguished then? This seems to be a bug in ffmpeg; using -- to separate options and filenames is wide-spread convention.

@phihag phihag closed this in 712e86b Jan 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants