Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tube8] Fixed video download and added channel download #32839

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

FildCommander
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

The current Version of the Tube8 Extractor is broken. I have changed it so that Videos can be extracted again.
I have also added a function to extract all Videos from a single channel.

Parts, especially for the channel videos, are taken from the YouPorn extractor.

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your good work!

I've had a look at the video extractor and made some suggestions. If you accept the relevant suggestion please include the mentioned mod to common.py -- as a separate commit.

Maybe there is scope to make a base class in the YouPorn module and import the "borrowed" code from there but that doesn't need to be done now.

I'll review the list extractor later if I may.

youtube_dl/extractor/tube8.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tube8.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tube8.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tube8.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tube8.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tube8.py Outdated Show resolved Hide resolved
youtube_dl/extractor/tube8.py Outdated Show resolved Hide resolved
Comment on lines 9 to 17
traverse_obj,
T,
url_or_none,
parse_iso8601,
get_element_by_class,
get_element_by_id,
int_or_none,
str_to_int,
parse_qs,
urljoin,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort these (case-insensitive, _ sorts first). Obvs also add any other imports implied by accepted changes below.

Comment on lines -26 to -27
'categories': ['Teen'],
'tags': ['dancing'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like these aren't being shown on the test video page. but age_limit must be set and duration is easily available. See comments below.

youtube_dl/extractor/tube8.py Show resolved Hide resolved
FildCommander and others added 2 commits July 15, 2024 18:38
added age_limit to test
changed info thumbnail check
@dirkf dirkf added the nsfw label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants