Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XVideos extractor #30689

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

DarkFighterLuke
Copy link

@DarkFighterLuke DarkFighterLuke commented Feb 26, 2022

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This PR containes these improvements:

  • extract category tags
  • extract creator
  • extract uploader, uploader_id and uploader_url
  • extract actors names (following the schema proposed by @dirkf in Actors extractor field #30672)
  • extract view_count

@afterdelight
Copy link
Contributor

downloading channel doesnt work from this branch

@DarkFighterLuke
Copy link
Author

downloading channel doesnt work from this branch

Can you provide an example to test?

@afterdelight
Copy link
Contributor

@DarkFighterLuke
Copy link
Author

DarkFighterLuke commented Mar 22, 2022

https://www.xvideos.com/channels/tianmeichuanmei

Tried with youtube-dl version 2021.12.17 (latest release), it doesn't work. So it's not related to this PR, it's a previously existing problem.

@afterdelight
Copy link
Contributor

i thought this PR contain this change:
extract uploader, uploader_id and uploader_url

@afterdelight
Copy link
Contributor

can u make it work with channels url?

@afterdelight
Copy link
Contributor

this git works
https://github.com/lonsty/xvideos-dl
can u implement it to yt-dl

@DarkFighterLuke
Copy link
Author

this git works https://github.com/lonsty/xvideos-dl can u implement it to yt-dl

This is the wrong place where to request a feature. You should open an appropriate issue, this PR is only about the things listed in the comment above and, at the moment, I have no time to work on the feature that you proposed, so you'll better open a feature request issue.

@afterdelight
Copy link
Contributor

ok

@dirkf
Copy link
Contributor

dirkf commented Mar 24, 2022

Nonetheless, I have a branch that handles playlists, searches and channels and will get posted when time allows.

@DarkFighterLuke
Copy link
Author

Yeah, but who reviews it? lol

@afterdelight
Copy link
Contributor

Nonetheless, I have a branch that handles playlists, searches and channels and will get posted when time allows.

Is it already available in the branch section? I can't find it.

@dirkf
Copy link
Contributor

dirkf commented Mar 25, 2022

PR #30774

dirkf added a commit to dirkf/youtube-dl that referenced this pull request Oct 16, 2023
* add uploader, tag, performer and view_count extraction (closes ytdl-org#30689)
* add dis/like_count extraction
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Oct 22, 2023
* add uploader, tag, performer and view_count extraction (closes ytdl-org#30689)
* add dis/like_count extraction
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Oct 22, 2023
* add uploader, tag, performer and view_count extraction (closes ytdl-org#30689)
* add dis/like_count extraction
@ifixthat-gmx
Copy link

Hello
This PR as well as dirkf's PR (30774) hasnt been merged yet.
I am currently working on an implementation in my fork, where I try to combine the modifications from @DarkFighterLuke , @dirkf with my own.
So I will probably do another PR when I finished and cleaned up the code.
You can check the code in my fork (https://github.com/ifixthat-gmx/ytdl-org---youtube-dl/tree/tmp-xvideos)

@dirkf dirkf added the nsfw label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants