-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve XVideos extractor #30689
base: master
Are you sure you want to change the base?
Improve XVideos extractor #30689
Conversation
modified: youtube_dl/extractor/xvideos.py
modified: youtube_dl/extractor/xvideos.py
downloading channel doesnt work from this branch |
Can you provide an example to test? |
Tried with youtube-dl version 2021.12.17 (latest release), it doesn't work. So it's not related to this PR, it's a previously existing problem. |
i thought this PR contain this change: |
can u make it work with channels url? |
this git works |
This is the wrong place where to request a feature. You should open an appropriate issue, this PR is only about the things listed in the comment above and, at the moment, I have no time to work on the feature that you proposed, so you'll better open a feature request issue. |
ok |
Nonetheless, I have a branch that handles playlists, searches and channels and will get posted when time allows. |
Yeah, but who reviews it? lol |
Is it already available in the branch section? I can't find it. |
PR #30774 |
* add uploader, tag, performer and view_count extraction (closes ytdl-org#30689) * add dis/like_count extraction
* add uploader, tag, performer and view_count extraction (closes ytdl-org#30689) * add dis/like_count extraction
* add uploader, tag, performer and view_count extraction (closes ytdl-org#30689) * add dis/like_count extraction
Hello |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR containes these improvements: