Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArteTV] config api v2 #29653

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

casaper
Copy link

@casaper casaper commented Jul 26, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Switch to ArteTV API v2, per #29640:

Also many closed duplicate issues:
#30912
#30927
#30930
#30951
#30963
#30980
#31006
#31020
#31242
#31292
#31389
#31455
#31510

@andreygursky
Copy link

Kaspar, just stumbled over youtube-dl not being able to download a video. It's almost exactly a month since you've noticed the new api. Thanks for reporting! Despite the old api is still working, some videos are not accessible through it.
Since your initial patch something has been already altered and simple https://static-cdn.arte.tv/guide/manifest.js is not available anymore. For now I was able to look up the token in browser.

@casaper
Copy link
Author

casaper commented Aug 27, 2021

@andreygursky

Despite the old api is still working, some videos are not accessible through it.

I wasn't aware. So far I assumed that this new API need would be something for the future.

Since your initial patch something has been already altered and simple https://static-cdn.arte.tv/guide/manifest.js is not available anymore. For now I was able to look up the token in browser.

I kind of assumed that it couldn't have been so easy. The PR is not finished anyway, so this code can't work as is... I just did not get around to continue yet.

Knowing that it might become more important to have the new API, might work as a better motivator to do so, since I'm regularly using this extractor myself. 😉

However: in case you have anything to contribute to this PR... I don't see this as a solo mission. So if that's the case I might have to give you access right to my fork, so you could push to the branch.

@dirkf
Copy link
Contributor

dirkf commented Feb 14, 2023

I hope you don't mind. I've updated this from a working WIP extractor back-ported from yt-dlp.

@dirkf dirkf marked this pull request as ready for review February 14, 2023 18:26
@dirkf dirkf linked an issue Feb 14, 2023 that may be closed by this pull request
6 tasks
youtube_dl/extractor/arte.py Outdated Show resolved Hide resolved
@casaper
Copy link
Author

casaper commented Feb 14, 2023

I hope you don't mind. I've updated this from a working WIP extractor bac-ported from yt-dlp.

Not at all, go ahead. I forgot this even exists.

Thx for finishing it.

@dirkf
Copy link
Contributor

dirkf commented Feb 15, 2023

Great, thanks.

I see that somehow the yt-dlp code didn't need to get the Bearer token, which makes things easier.

Based on yt-dlp/yt-dlp 051d6b4 merging [extractor/arte] yt-dlp/yt-dlp#3302: Move to v2 API

Authored by: fstirlitz, pukkandan
youtube_dl/extractor/arte.py Outdated Show resolved Hide resolved
@dirkf dirkf changed the title WIP: arte config api v2 [ArteTV] config api v2 Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants