-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[embedthumbnail] use ffmpeg to m4a/mp4 if version >= 4.0 #29593
base: master
Are you sure you want to change the base?
Conversation
Why is this not being merged yet? |
Anybody home? Since some time I'm not able to compile my custom youtube-dl with #29581 and #29593 integrated, due to conflicts that have emerged. User @ghost seems deleted from GitHub... @dirkf, what are your thoughts? |
For the record, there is a procedure to revive a PR where the original repo has gone. Let's use 29593 as an example;
Eventually, I'll do that for this PR, but anyone is very welcome to accelerate the process. |
I think I have working code right now (tested with one m4a download). I don't dare to make a pull request, because I have no idea to test properly, so I couldn't check these boxes: |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Resolves #24882, and maybe #29563
Needs my #29581
ffmpeg supports embedding thumbnails to m4a/mp4 from version 4.0 (has been supported in api since before).
This PR checks ffmpeg version (actually libavformat build version) and if newer enough use ffmpeg instead of not actively maintained atomicparsley.