Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[peertube] only call description endpoint if necessary #29383

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

B0pol
Copy link
Contributor

@B0pol B0pol commented Jun 24, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

  • Searched the bugtracker for similar pull requests
  • Read adding new extractor tutorial
  • Read youtube-dl coding conventions and adjusted the code to meet them
  • Covered the code with tests (note that PRs without tests will be REJECTED) ("what is peertube" video description is already in tests and is above 250 characters so an extra api call is needed).
  • Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Prevent an useless call to API by checking if the description is shortened and only requesting the full description to the API if necessary.

@remitamine remitamine merged commit a803582 into ytdl-org:master Jul 1, 2021
gaming-hacker added a commit to gaming-hacker/youtube-dl that referenced this pull request Sep 3, 2021
* commit '188b7b108e1cd287580bee5dba8075e669c29a10': (192 commits)
  Avoid skipping ID when unlisted_hash is numeric
  [peertube] only call description endpoint if necessary (ytdl-org#29383)
  [periscope] pass referer to HLS requests(closes ytdl-org#29419)
  [liveleak] Remove extractor (closes ytdl-org#17625, closes ytdl-org#24222) (ytdl-org#29331)
  [pornhub] Add support for pornhubthbh7ap3u.onion
  [pornhub] Detect geo restriction
  [pornhub] Dismiss tbr extracted from download URLs (closes ytdl-org#28927)
  [curiositystream:collection] Extend _VALID_URL (closes ytdl-org#26326, closes ytdl-org#29117)
  [youtube] Make get_video_info processing more robust (closes ytdl-org#29333)
  [youtube] Workaround for get_video_info request (refs ytdl-org#29333)
  [bilibili] Strip uploader name (ytdl-org#29202)
  [youtube] Update invidious instance list (ytdl-org#29281)
  [umg:de] Update GraphQL API URL (ytdl-org#29304)
  [nrk] Switch psapi URL to https (closes ytdl-org#29344)
  [postprocessor/ffmpeg] Show ffmpeg output on error (refs ytdl-org#22680) (ytdl-org#29336)
  [egghead] Add support for app.egghead.io (closes ytdl-org#28404) (ytdl-org#29303)
  [appleconnect] Fix extraction (ytdl-org#29208)
  [orf:tvthek] Add support for MPD formats (closes ytdl-org#28672) (ytdl-org#29236)
  [README.md] Update MSVC 2010 redist URL (closes ytdl-org#29222)
  release 2021.06.06
  ...

# Conflicts:
#	youtube_dl/extractor/generic.py
@Lesmiscore Lesmiscore mentioned this pull request Feb 20, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants