Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kaltura] Add support for an uncommon typo in a GDC Vault page #28969

Merged
merged 2 commits into from
May 4, 2021
Merged

[Kaltura] Add support for an uncommon typo in a GDC Vault page #28969

merged 2 commits into from
May 4, 2021

Conversation

zorbathut
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

A few pages on the GDC Vault (https://www.gdcvault.com/play/1025699, https://www.gdcvault.com/play/1025739, possibly more) have a slightly-misformed Kaltura iframe link, where the URL has an unnecessary leading space. The Kaltura extractor isn't durable enough to ignore that so it fails to download the file. Web browsers seem happy to skip it, however.

This allows it to ignore that initial leading space when it exists.

This is a repost of #21079 which got kinda nuked in the whole DMCA thing.

@dstftw
Copy link
Collaborator

dstftw commented May 4, 2021

Does not seem to have any effect:

> py -3.7 .\youtube_dl\__main__.py https://www.gdcvault.com/play/1025699 -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.gdcvault.com/play/1025699', '-v']
[debug] Encodings: locale cp1251, fs utf-8, out utf-8, pref cp1251
[debug] youtube-dl version 2021.04.26
[debug] Git HEAD: 61d7f7d
[debug] Python version 3.7.0 (CPython) - Windows-10-10.0.10240-SP0
[debug] exe versions: ffmpeg N-85653-gb4330a0, ffprobe N-85653-gb4330a0, phantomjs 2.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[GDCVault] 1025699: Downloading webpage
WARNING: [GDCVault] It looks like http://www.gdcvault.com/play/1025699 requires a login. Try specifying a username and password and try again.
WARNING: [GDCVault] Could not login.
ERROR: Unable to extract xml filename; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Add: it's because kaltura alternatives didn't work.

@zorbathut
Copy link
Author

You'll need a GDC Vault login to test it, unfortunately; it's joining a similar group because very few of the tests in there still work.

@dstftw
Copy link
Collaborator

dstftw commented May 4, 2021

This has nothing to do with GDC Vault login. The video is freely available.

@dstftw dstftw merged commit fe05191 into ytdl-org:master May 4, 2021
@zorbathut zorbathut deleted the kalturaspace branch May 5, 2021 05:17
fossdd pushed a commit to ex-dl/ex-dl that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants