[americastestkitchen] Fix metadata extraction for ATK episodes #27860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @remitamine this may be related to 17b0122 |
remitamine
requested changes
Jan 18, 2021
| 'release_date': unified_strdate(video.get('publishDate')), | ||
| 'upload_date': unified_strdate(video.get('publishDate')), |
There was a problem hiding this comment.
remove this line(will be calculated automatically from timestamp).
| @@ -33,6 +34,25 @@ class AmericasTestKitchenIE(InfoExtractor): | |||
| 'params': { | |||
| 'skip_download': True, | |||
| }, | |||
| }, { | |||
| 'url': 'https://www.americastestkitchen.com/episode/705-simple-chicken-dinner', | |||
There was a problem hiding this comment.
Add a comment on why this test has been added.
Comment on lines
86
to
87
| 'episode_number': episode.get('number'), | ||
| 'season_number': episode.get('season'), |
There was a problem hiding this comment.
same for episode_number(both lines where highlighted).
There was a problem hiding this comment.
My mistake. Just fixed this!
bm1549
force-pushed
the
add-atk-metadata
branch
from
94defe7 to
9130ebc
Compare
bm1549
commented
Jan 18, 2021
| @@ -80,11 +83,10 @@ def _real_extract(self, url): | |||
| 'url': 'https://player.zype.com/embed/%s.js?api_key=jZ9GUhRmxcPvX7M3SlfejB6Hle9jyHTdk2jVxG7wOHPLODgncEKVdPYBhuz9iWXQ' % video['zypeId'], | |||
| 'ie_key': 'Zype', | |||
| 'description': clean_html(video.get('description')), | |||
| 'timestamp': parse_iso8601(video.get('publishDate')), | |||
| 'timestamp': unified_timestamp(video.get('publishDate')), | |||
There was a problem hiding this comment.
The timestamp was not a valid iso8601 timestamp. This fixes that issue and the timestamp in the second test case proves it
bm1549
changed the title
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
Although the API does not appear to have changed between episode 582 and episode 705, the existing code fails to extract the metadata correctly for episode 705. This PR updates the metadata extraction to work well with the ATK api.