[vvvvid] add playlists support #27574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remitamine
requested changes
Dec 29, 2020
remitamine
requested changes
Dec 29, 2020
- removed duplication for _download_info #27574 (comment) - removed custom title creation #27574 (comment) - improved missing value checks as suggested #27574 (comment) - check if 'episodes' exist #27574 (comment) - checks to avoid Fatals #27574 (comment) - improved regex #27574 (comment) - added playlist_description #27574 (comment)
remitamine
requested changes
Dec 30, 2020
remitamine
requested changes
Dec 30, 2020
- changed 'id' in 'show_title' as it's more accurate #27574 (comment) and #27574 (comment) - removed unnecessary urljoin #27574 (comment) - changed args in playlist_result call #27574 (comment) - moved response['data'] inside _download_info as suggested #27574 (comment) - added Fatal args and moved %s inside _download_info #27574 (comment)
|
thanks for the time dedicated to this PR. I wish you a happy new year. |
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Add support for playlist in the VVVVID website.
Solves #18130