Fix for #27455. Adapted StreetVoice extractor to new API and fixed tests #27492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PaaaulZ
changed the title
PaaaulZ
changed the title
|
I did check the guidelines before submitting the PR, considering that I changed as little as possible from the original code maybe I'm missing something. |
|
Mainly, the Mandatory and optional metafields section, the extraction will break if optional fields are not available. |
|
Damn you are right I'm sorry, I'll fix it later and squash the commits |
remitamine
requested changes
Dec 21, 2020
flake8 Adapted to youtube-dl coding conventions and cleaned code Added check for optional parameters, added all supported meta
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fix for issue #27455 . StreetVoice API changed and support for that site broke, I also fixed the test that pointed to an invalid url because the song was removed.