Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reddit] Add duration to extracted information for posts containing a v.redd.it video #27426

Merged
merged 8 commits into from
Dec 17, 2020
Merged

Conversation

trevnels
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Previously, the Reddit extractor would not provide video duration for post videos served through v.redd.it, though this information is provided by the Reddit post API. This change includes the duration key of the API response in the video's extracted information when present. I also added duration to the existing test's info_dict for coverage.

@dstftw
Copy link
Collaborator

dstftw commented Dec 14, 2020

Read coding conventions.

@trevnels
Copy link
Contributor Author

@dstftw I believe this is now correct.

@dstftw
Copy link
Collaborator

dstftw commented Dec 17, 2020

  • Checked the code with flake8

@dstftw dstftw merged commit 76fe4ba into ytdl-org:master Dec 17, 2020
ThirumalaiK pushed a commit to ThirumalaiK/youtube-dl that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants