Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audius] Add new extractor #27360

Closed
wants to merge 2 commits into from
Closed

[Audius] Add new extractor #27360

wants to merge 2 commits into from

Conversation

qulaz
Copy link

@qulaz qulaz commented Dec 9, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Add an extractor for Audius, a music streaming and sharing platform (like SoundCloud). Also this was requested in #24216

@dstftw
Copy link
Collaborator

dstftw commented Dec 11, 2020

Read coding conventions.

@qulaz
Copy link
Author

qulaz commented Jan 9, 2021

I fixed all the code style issues I could see.

But i need help. Since first commit Audius changed a little bit. Audius is decentralized platform and they has multiple API hosts the list of which can be obtained using a special REST endpoint. Point is that before this list looked something like this:

https://discoveryprovider1.audius.co
https://discoveryprovider2.audius.co
...

But now it's looks something like this:

https://audius-metadata-2.figment.io
https://discoveryprovider.audius2.prod-us-west-2.staked.cloud
https://audius-dp.johannesburg.creatorseed.com
https://discovery-au-01.audius.openplayer.org
https://dn-jpn.audius.metadata.fyi
https://audius-disco.ams-x01.nl.supercache.org
https://audius-discovery.nz.modulational.com
...

The problem is that I have no idea how handle all of this different hosts with regexp. For now, as a temporary solution, i used .+/v1/tracks regexp, but then this extractor will triggered to links like https://super-random-host.com/v1/tracks/trackID. For now such links do not overlap with other extractors, but who knows what will happen next.

pukkandan added a commit to yt-dlp/yt-dlp that referenced this pull request Jan 29, 2021
Related: ytdl-org/youtube-dl#27360
Related: ytdl-org/youtube-dl#24216

Direct API URLs are not currently supported. See ytdl-org/youtube-dl#27360 (comment) for details

Co-authored by: qulas
@qulaz qulaz closed this by deleting the head repository Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants