Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autonumber man page item #26686

Closed
wants to merge 1 commit into from
Closed

Fix autonumber man page item #26686

wants to merge 1 commit into from

Conversation

jesus2099
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

In the man youtube-dl page, the autonumber description is wrong.

The output format autonumber does not start at zero (as the man page says), it starts at 00001 (as verified and as written elsewhere in the same man page).

I hope changing the README.md will change the man page. I didn't find this description anywhere else in the repo.

The output format autonumber does not start at zero, it starts at 00001 (as verified and as written elsewhere in the same man page).
@dstftw
Copy link
Collaborator

dstftw commented Sep 23, 2020

This depends on the conversion type used.

@dstftw dstftw closed this Sep 23, 2020
@dstftw dstftw added the invalid label Sep 23, 2020
@jesus2099
Copy link
Author

Hello @dstftw.

I don't know in which cases it starts at zero (maybe the doc should explain that) because it always started at 00001 for me.

The issue is that these two lines, both in the same README.md, are in contradiction:

--autonumber-start NUMBER Specify the start value for %(autonumber)s (default is 1)

autonumber (numeric): Five-digit number that will be increased with each download, starting at zero

And... both are wrong if This depends on the conversion type used. 😉

@dstftw
Copy link
Collaborator

dstftw commented Sep 23, 2020

I mean it depends on conversion type whether it will be prefixed with leading zeros or not. It always starts at --autonumber-start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants