[youtube] Fix empty description extraction #26575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
In its current state, the YouTube description extraction logic only checks if
shortDescription
fromvideo_details
is truthy, which it is not if it's an empty string when there is no description. As a result of that, it uses thedescription
meta tag, which has a default value ofEnjoy the videos and music you love, upload original content, and share it all with friends, family, and the world on YouTube.
. This PR changes this behaviour to only use the meta tag ifshortDescription
is None (= doesn't exist) and adds a test for it.