[xhamster] Initials RegEx changed #26526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
I noticed a problem again with the RegEx for the site initials, with patch #26254. As it looks like the web server has problems to deliver the line completely. On the other hand, the character ; appears more often in the line now.
I have tested a few lines:
r'window.initials\s*=\s*({.+?})\s*;', webpage, 'initials',
r'window.initials\s*=\s*({.+?})\s*;<', webpage, 'initials', #minimal changed
r'<script\sid='initials-script'>window.initials\s=\s*({.+?})\s*;</script>', webpage, 'initials',
r'window.initials\s*=\s*({.+?})\s*;\s*</script>', webpage, 'initials',
I prefer the last one. i think this is the most robust version for changes to the line on the website.
Closes #26353