Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zingmp3_vn] Add new extractor #24511

Closed
wants to merge 3 commits into from
Closed

[zingmp3_vn] Add new extractor #24511

wants to merge 3 commits into from

Conversation

hatienl0i2612
Copy link

@hatienl0i2612 hatienl0i2612 commented Mar 28, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

  • I see the zingmp3.py site is using an old version is mp3.zing.vn
  • I have added a new extractor, zingmp3_vn.py, supporting the latest version is zingmp3.vn

@dstftw
Copy link
Collaborator

dstftw commented Mar 31, 2020

Read tutorial and coding conventions.

@hatienl0i2612
Copy link
Author

I have read the tutorial, I do not know what error I have in coding conventions.

@hatienl0i2612
Copy link
Author

i don't know where is the bug in coding conventions

@hatienl0i2612
Copy link
Author

Can someone help me know where I have the error in coding conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants