Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redtube view count and upload date extraction #22615

Closed
wants to merge 1 commit into from

Conversation

gergesh
Copy link

@gergesh gergesh commented Oct 5, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Fixes extraction of view count and upload date for redtube videos, as noted in #22492

@gergesh
Copy link
Author

gergesh commented Oct 5, 2019

Also to note - I'm parsing this information from a json embedded in the webpage that contains some more info - notably video title, description, thumbnail url and duration.
Maybe it'd be better (faster?) to just parse this json and extract information from it instead of running regexes on the page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant