Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telequebec] Support coucou subdomain URLs #22482

Merged
merged 2 commits into from
Oct 4, 2019
Merged

[telequebec] Support coucou subdomain URLs #22482

merged 2 commits into from
Oct 4, 2019

Conversation

waptaff
Copy link
Contributor

@waptaff waptaff commented Sep 22, 2019

The zonevideo.telequebec.tv code works on coucou.telequebec.tv, so just
ensure those coucou URLs are recognized.

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

@dstftw
Copy link
Collaborator

dstftw commented Sep 24, 2019

Don't capture groups you don't use. Read coding conventions. Add tests.

@Thieum
Copy link

Thieum commented Sep 24, 2019

Would it work with squat too? see #18503

@waptaff
Copy link
Contributor Author

waptaff commented Sep 30, 2019

Would it work with squat too? see #18503

Unfortunately no, more code changes will be needed for squat :(

The zonevideo.telequebec.tv code works on coucou.telequebec.tv, so just
ensure those coucou URLs are recognized.
@waptaff
Copy link
Contributor Author

waptaff commented Oct 2, 2019

Don't capture groups you don't use. Read coding conventions. Add tests.

Done. Please re-evaluate this pull request.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants