[xvideos] Add support for alternative urls. #22471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for alternative xvideos urls.
Stephan972
changed the title
Stephan972
changed the title
dstftw
requested changes
Sep 24, 2019
youtube_dl/extractor/xvideos.py
Outdated
| @@ -17,7 +17,8 @@ class XVideosIE(InfoExtractor): | |||
| _VALID_URL = r'''(?x) | |||
| https?:// | |||
| (?: | |||
| (?:www\.)?xvideos\.com/video| | |||
| (?:(?:fr|it|de|www)\.)?xvideos2?\.com/video| | |||
There was a problem hiding this comment.
There are more country domains.
There was a problem hiding this comment.
There are more country domains
When I wrote the regex, I used the html code from the https://xvideos.com main page. A part from 'fr', 'it' and 'de' xvideos.com subdomains and xvideos.es there were no other country domains.
All other countries lead to www.xvideos2.com.
Here is an excerpt from this html code (as of 2019-09-28)
<link rel="alternate" href="https://www.xvideos.com/" hreflang="x-default" />
<link rel="alternate" href="https://www.xvideos2.com/" hreflang="en-IN" />
<link rel="alternate" href="https://www.xvideos2.com/" hreflang="hi" />
<link rel="alternate" href="https://www.xvideos2.com/" hreflang="bn" />
<link rel="alternate" href="https://www.xvideos2.com/" hreflang="mr" />
<link rel="alternate" href="https://www.xvideos2.com/" hreflang="te" />
<link rel="alternate" href="https://www.xvideos2.com/" hreflang="ta" />
<link rel="alternate" href="https://www.xvideos2.com/" hreflang="kn" />
<link rel="alternate" href="https://www.xvideos2.com/" hreflang="gu" />
<link rel="alternate" href="https://www.xvideos2.com/" hreflang="or" />
<link rel="alternate" href="https://www.xvideos2.com/" hreflang="ml" />
<link rel="alternate" href="https://www.xvideos.es/" hreflang="es" />
<link rel="alternate" href="https://fr.xvideos.com/" hreflang="fr" />
<link rel="alternate" href="https://it.xvideos.com/" hreflang="it" />
<link rel="alternate" href="https://de.xvideos.com/" hreflang="de" />
As of this writing, https://www.xvideos.cm/ exists. However it seems to be a chaturbate like website. xvideos.desi is a parked domain.
@dstftw Do you see any other country domain needing to be added?
meunierd
referenced
this pull request
in meunierd/youtube-dl
Feb 13, 2020
pareronia
referenced
this pull request
in pareronia/youtube-dl
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
ytdl doesn't recognize xvideos urls like the one below :
https://fr.xvideos.com/video13287221/
Did you notice the 'fr' subdomain before 'xvideos.com' domain ?
This patch addresses this issue and other alternative valid xvideos urls rejected by youtube-dl.
xvideos2.com, xvideos.es, it.xvideos.com, de.xvideos.com.