Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dlive] extend VALID_URL regex to support VID with hyphens #21909

Merged
merged 4 commits into from
Jul 30, 2019
Merged

[dlive] extend VALID_URL regex to support VID with hyphens #21909

merged 4 commits into from
Jul 30, 2019

Conversation

CeruleanSky
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Some dlive VIDs such as the one found in https://dlive.tv/p/pdpreplay+D-RD-xSZg contain hyphens, so modified _VALID_URL accordingly.

Some VIDs contain hyphens, so modified _VALID_URL accordingly.
@dstftw
Copy link
Collaborator

dstftw commented Jul 27, 2019

Add test.

@dstftw dstftw merged commit 07ab44c into ytdl-org:master Jul 30, 2019
@CeruleanSky CeruleanSky deleted the patch-1 branch July 30, 2019 18:52
kylepw referenced this pull request in kylepw/youtube-dl Aug 1, 2019
Lamieur referenced this pull request in Lamieur/youtube-dl Aug 3, 2019
meunierd referenced this pull request in meunierd/youtube-dl Feb 13, 2020
Lamieur referenced this pull request in Lamieur/youtube-dl Apr 20, 2020
Lamieur referenced this pull request in Lamieur/youtube-dl Apr 20, 2020
pareronia referenced this pull request in pareronia/youtube-dl Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants