New regex for extracting series title #21834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #21833
dstftw
requested changes
Jul 20, 2019
youtube_dl/extractor/tvn24.py
Outdated
| title = self._og_search_title(webpage) | ||
| title = self._html_search_regex( | ||
| r'<span[^>]+class="standardHeader1[^"]*"[^>]*>\s*(.+?)\s*</span>', | ||
| webpage, 'title', default=None) |
There was a problem hiding this comment.
Title is mandatory. Read coding conventions.
youtube_dl/extractor/tvn24.py
Outdated
| @@ -39,7 +39,10 @@ def _real_extract(self, url): | |||
|
|
|||
| webpage = self._download_webpage(url, video_id) | |||
|
|
|||
| title = self._og_search_title(webpage) | |||
| title = self._html_search_regex( | |||
| r'<span[^>]+class="standardHeader1[^"]*"[^>]*>\s*(.+?)\s*</span>', | |||
There was a problem hiding this comment.
- It's not a title. You must extract title of the video not series.
class=standardHeader1pattern is too ambiguous and not future-proof since it occurs multiple times on the page though not in span currently.
youtube_dl/extractor/tvn24.py
Outdated
| title = self._html_search_regex( | ||
| r'<span[^>]+class="standardHeader1[^"]*"[^>]*>\s*(.+?)\s*</span>', | ||
| webpage, 'title', default=None) | ||
|
|
There was a problem hiding this comment.
Remove all meaningless changes.
dstftw
reviewed
Jul 30, 2019
| title = self._og_search_title(webpage) | ||
| title = self._html_search_regex( | ||
| r'<span[^>]+class="standardHeader1 headerPadding header-span headerMargin"[^>]*>\s*(.+?)\s*</span>', | ||
| webpage, 'title') |
There was a problem hiding this comment.
Have you read review comments at all?
dstftw
reviewed
Jul 30, 2019
| title = self._og_search_title(webpage) | ||
| title = self._html_search_regex( | ||
| r'<span[^>]+class="standardHeader1 headerPadding header-span headerMargin"[^>]*>\s*(.+?)\s*</span>', | ||
| webpage, 'title') |
There was a problem hiding this comment.
This also breaks currently working tests.
kylepw
referenced
this pull request
in kylepw/youtube-dl
Aug 1, 2019
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Aug 3, 2019
meunierd
referenced
this pull request
in meunierd/youtube-dl
Feb 13, 2020
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Apr 20, 2020
This reverts commit 70066c1.
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Apr 20, 2020
This reverts commit 70066c1.
pareronia
referenced
this pull request
in pareronia/youtube-dl
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21833
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fix for changed site HTML #21833
Apparently there's a big refactoring of this module in https://github.com/ytdl-org/youtube-dl/pull/20698/files apparently, but this is a quick fix which restores it to working state, and the other one seems to be in development for a long time.