[einthusan] adding .com tld #21775
Merged
[einthusan] adding .com tld #21775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Jul 14, 2019
youtube_dl/extractor/einthusan.py
Outdated
| @@ -18,7 +19,7 @@ | |||
|
|
|||
|
|
|||
| class EinthusanIE(InfoExtractor): | |||
| _VALID_URL = r'https?://einthusan\.tv/movie/watch/(?P<id>[^/?#&]+)' | |||
| _VALID_URL = r'https?://einthusan\.(?P<tld>tv|com)/movie/watch/(?P<id>[^/?#&]+)' | |||
There was a problem hiding this comment.
Capture entire host with scheme.
dstftw
requested changes
Jul 15, 2019
youtube_dl/extractor/einthusan.py
Outdated
| @@ -18,7 +19,7 @@ | |||
|
|
|||
|
|
|||
| class EinthusanIE(InfoExtractor): | |||
| _VALID_URL = r'https?://einthusan\.tv/movie/watch/(?P<id>[^/?#&]+)' | |||
| _VALID_URL = r'https?://(?P<host>einthusan\.(tv|com))/movie/watch/(?P<id>[^/?#&]+)' | |||
There was a problem hiding this comment.
Do not capture groups you don't use.
dstftw
requested changes
Jul 15, 2019
youtube_dl/extractor/einthusan.py
Outdated
| @@ -18,7 +19,7 @@ | |||
|
|
|||
|
|
|||
| class EinthusanIE(InfoExtractor): | |||
| _VALID_URL = r'https?://einthusan\.tv/movie/watch/(?P<id>[^/?#&]+)' | |||
| _VALID_URL = r'https?://(?P<host>einthusan\.(tv|com))/movie/watch/(?P<id>[^/?#&]+)' | |||
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Aug 3, 2019
meunierd
referenced
this pull request
in meunierd/youtube-dl
Feb 13, 2020
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Apr 20, 2020
…1775)" This reverts commit 97d98a8.
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Apr 20, 2020
…1775)" This reverts commit 97d98a8.
pareronia
referenced
this pull request
in pareronia/youtube-dl
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
einthusan.tv is having some issues with their normal domain, and have added einthusan.com as an additional domain. My addition extracts the tld and downloads from that tld, specifically.