[CtsNews] Fix YouTube embed video url regex and test cases #21678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Jul 7, 2019
youtube_dl/extractor/ctsnews.py
Outdated
| @@ -63,7 +63,8 @@ def _real_extract(self, url): | |||
| else: | |||
| self.to_screen('Not CTSPlayer video, trying Youtube...') | |||
| youtube_url = self._search_regex( | |||
| r'src="(//www\.youtube\.com/embed/[^"]+)"', page, 'youtube url') | |||
| r'src="(https?://www.youtube.com/embed/[^"]+)"', page, 'youtube url') | |||
There was a problem hiding this comment.
No. _extract_urls of youtube extractor.
youtube_dl/extractor/ctsnews.py
Outdated
| @@ -63,7 +63,8 @@ def _real_extract(self, url): | |||
| else: | |||
| self.to_screen('Not CTSPlayer video, trying Youtube...') | |||
| youtube_url = self._search_regex( | |||
| r'src="(//www\.youtube\.com/embed/[^"]+)"', page, 'youtube url') | |||
| r'src="(https?://www.youtube.com/embed/[^"]+)"', page, 'youtube url') | |||
| print(youtube_url) | |||
chien-yu
force-pushed
the
bugfix/IE_CtsNews-youtube-embed
branch
from
f834ebe to
281db3a
Compare
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Aug 3, 2019
meunierd
referenced
this pull request
in meunierd/youtube-dl
Feb 13, 2020
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Apr 20, 2020
This reverts commit 8c5c367.
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Apr 20, 2020
This reverts commit 8c5c367.
pareronia
referenced
this pull request
in pareronia/youtube-dl
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fixed the YouTube embedded video URL regex pattern, somehow it was missing the "https" part in the beginning. I have tested this extractor's 3 unit test cases and updated the other 2 description.