Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedthumbnail option #21569

Closed
wants to merge 2 commits into from
Closed

Conversation

pauldubois98
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

When downloading mp3 from Youtube, the embedthumbnail option doesn't work properly: the thumbnail is only displayed with VLC, but not with other mp3 readers (as the standards Windows ones, as well and Android ones).
This is a very small issue, only some arguments when calling FFmpeg have been changed.

added a missing argument when calling FFmpeg
Patch --embed-thumbnail option via the embedthumbnail.py file
@Magnusmm1999
Copy link

Can confirm this fixed my issues tyvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants